Skip to content

Stav/move prover input info to seperate file #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: starkware-development
Choose a base branch
from

Conversation

Stavbe
Copy link
Collaborator

@Stavbe Stavbe commented Apr 29, 2025

No description provided.

@Stavbe Stavbe changed the base branch from main to starkware-development April 29, 2025 14:41
@Stavbe Stavbe force-pushed the stav/move_prover_input_info_to_seperate_file branch from 99e1a1c to b5a9ed1 Compare April 29, 2025 14:48
Copy link

github-actions bot commented Apr 29, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.276 s ±  0.045 s    [User: 25.469 s, System: 0.804 s]
  Range (min … max):   26.245 s … 26.308 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.634 s ±  0.022 s    [User: 25.784 s, System: 0.847 s]
  Range (min … max):   26.619 s … 26.650 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.01 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.578 s ±  0.064 s    [User: 25.519 s, System: 0.831 s]
  Range (min … max):   14.533 s … 14.623 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.848 s ±  0.029 s    [User: 25.895 s, System: 0.894 s]
  Range (min … max):   14.828 s … 14.868 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.02 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.420 s ±  0.531 s    [User: 38.016 s, System: 0.952 s]
  Range (min … max):   10.044 s … 10.795 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     11.019 s ±  0.429 s    [User: 38.533 s, System: 1.013 s]
  Range (min … max):   10.716 s … 11.322 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.06 ± 0.07 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.127 s ±  0.158 s    [User: 38.240 s, System: 0.967 s]
  Range (min … max):   10.015 s … 10.239 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.465 s ±  0.231 s    [User: 39.393 s, System: 1.059 s]
  Range (min … max):   10.302 s … 10.628 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.03 ± 0.03 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.354 s ±  0.065 s    [User: 37.992 s, System: 0.989 s]
  Range (min … max):   10.308 s … 10.400 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.659 s ±  0.053 s    [User: 39.195 s, System: 1.092 s]
  Range (min … max):   10.622 s … 10.697 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.03 ± 0.01 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.349 s ±  0.019 s    [User: 38.379 s, System: 1.098 s]
  Range (min … max):   10.335 s … 10.362 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.574 s ±  0.168 s    [User: 39.625 s, System: 1.148 s]
  Range (min … max):   10.456 s … 10.693 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.02 ± 0.02 times faster than hyper_threading_pr threads: 16


@Stavbe Stavbe force-pushed the stav/move_prover_input_info_to_seperate_file branch from b5a9ed1 to 9f38cc9 Compare April 29, 2025 15:03
@Stavbe Stavbe self-assigned this Apr 29, 2025
@Stavbe Stavbe marked this pull request as ready for review April 29, 2025 15:09
@Stavbe Stavbe force-pushed the stav/move_prover_input_info_to_seperate_file branch from 9f38cc9 to 94908e8 Compare April 29, 2025 15:11
Copy link

github-actions bot commented Apr 29, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.156 ± 0.007 2.149 2.172 1.00 ± 0.01
head big_factorial 2.147 ± 0.015 2.131 2.187 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.087 ± 0.018 2.074 2.137 1.01 ± 0.01
head big_fibonacci 2.062 ± 0.007 2.055 2.075 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.944 ± 0.075 7.891 8.132 1.01 ± 0.01
head blake2s_integration_benchmark 7.836 ± 0.021 7.800 7.873 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.248 ± 0.007 2.236 2.258 1.01 ± 0.01
head compare_arrays_200000 2.237 ± 0.012 2.213 2.258 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.474 ± 0.023 1.455 1.526 1.01 ± 0.02
head dict_integration_benchmark 1.460 ± 0.004 1.451 1.466 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.246 ± 0.012 1.235 1.273 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.236 ± 0.011 1.228 1.268 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.973 ± 0.044 7.944 8.080 1.01 ± 0.01
head integration_builtins 7.882 ± 0.033 7.842 7.955 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.289 ± 0.061 8.244 8.444 1.01 ± 0.01
head keccak_integration_benchmark 8.175 ± 0.031 8.143 8.230 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.204 ± 0.009 2.194 2.219 1.01 ± 0.01
head linear_search 2.187 ± 0.022 2.174 2.247 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.528 ± 0.003 1.523 1.532 1.00 ± 0.00
head math_cmp_and_pow_integration_benchmark 1.524 ± 0.002 1.520 1.529 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.471 ± 0.012 1.456 1.503 1.00 ± 0.01
head math_integration_benchmark 1.468 ± 0.003 1.463 1.473 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.230 ± 0.013 1.221 1.266 1.01 ± 0.01
head memory_integration_benchmark 1.220 ± 0.003 1.216 1.226 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.583 ± 0.002 1.580 1.586 1.00
head operations_with_data_structures_benchmarks 1.589 ± 0.014 1.576 1.624 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 537.0 ± 2.0 534.7 540.8 1.00 ± 0.00
head pedersen 535.2 ± 1.3 533.1 537.9 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 644.9 ± 3.7 640.6 652.7 1.01 ± 0.01
head poseidon_integration_benchmark 641.6 ± 4.3 637.9 649.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.881 ± 0.009 1.868 1.899 1.01 ± 0.01
head secp_integration_benchmark 1.871 ± 0.008 1.858 1.884 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 630.6 ± 1.3 629.2 632.3 1.00
head set_integration_benchmark 631.6 ± 2.6 628.3 637.0 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.437 ± 0.282 4.318 5.229 1.03 ± 0.07
head uint256_integration_benchmark 4.295 ± 0.014 4.272 4.312 1.00

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.52%. Comparing base (33d75ca) to head (a292dee).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           starkware-development    #2079      +/-   ##
=========================================================
- Coverage                  96.62%   96.52%   -0.10%     
=========================================================
  Files                        102      103       +1     
  Lines                      44388    43198    -1190     
=========================================================
- Hits                       42889    41697    -1192     
- Misses                      1499     1501       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Stavbe Stavbe force-pushed the stav/move_prover_input_info_to_seperate_file branch from 94908e8 to a292dee Compare May 4, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant