-
Notifications
You must be signed in to change notification settings - Fork 55
perf(l1): reduce transaction clone and Vec grow overhead in mempool #2637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Lines of code reportTotal lines added: Detailed view
|
some local bench load tests Specs: Commands
main (33e34ef) PR #2637 (9eb253e) |
Benchmark Block Execution Results Comparison Against Main
|
Using load-test-erc20 main: Load test finished. Elapsed time: 433 seconds main |
Motivation
Improve perfomance
Description
Reduces transaction clone overhead on the mempool and Vec initial grow overhead.
The main focus on this pr was the mempool fetch transaction method whose overhead before was 15%
, reducing it to 13%, whose main time is spent in the filter transaction method, which had a clone taking 5% of the time now reduced to non existent levels using an Arc.Images of the perf profile:
Before
After
Closes #issue_number