-
Notifications
You must be signed in to change notification settings - Fork 56
refactor(l2): rewrite deployer and system contracts updater bins #2643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add deploy_contract function - Add compile_contract function - Add initialize_contract function
- Move to `bin/system_contract_updates` module - Add `cli.rs` module with simple arg parser - Add `error.rs` module
- Move to `bin/deployer` module - Add `cli.rs` module with simple arg parser - Add `error.rs` module
Lines of code reportTotal lines added: Detailed view
|
…rex into l1_deployer_cli
…rex into l1_deployer_cli
…rex into l1_deployer_cli
…rex into l1_deployer_cli
…rex into l1_deployer_cli
ManuelBilbao
reviewed
May 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice overall
Co-authored-by: Manuel Iñaki Bilbao <[email protected]>
ManuelBilbao
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
pr-main_l2
workflow.sequencer_config_example.toml
since it is not needed anymore.crates/l2/contracts
moduleethrex-l2_deployer
toethrex-l2_contracts
.bin
module with the binsethrex_l2_l1_deployer
andethrex_l2_system_contracts_updater
.Closes #2609.