Skip to content

docs(levm): add forks docs #2644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2025
Merged

docs(levm): add forks docs #2644

merged 5 commits into from
May 6, 2025

Conversation

JereSalo
Copy link
Contributor

Description

  • Add docs about forks explaining why we don't want to support pre-Merge forks.
  • Change EFTests so they run by default for the forks we are interested in.

@JereSalo JereSalo added docs Improvements or additions to documentation levm Lambda EVM implementation labels Apr 29, 2025
@JereSalo JereSalo self-assigned this Apr 29, 2025
Copy link

github-actions bot commented Apr 29, 2025

Lines of code report

Total lines added: 5
Total lines removed: 0
Total lines changed: 5

Detailed view
+-----------------------------------------+-------+------+
| File                                    | Lines | Diff |
+-----------------------------------------+-------+------+
| ethrex/cmd/ef_tests/state/runner/mod.rs | 231   | +5   |
+-----------------------------------------+-------+------+

Copy link

github-actions bot commented Apr 29, 2025

Benchmark Results Comparison

PR Results

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Factorial 238.3 ± 1.2 235.7 240.1 1.00
levm_Factorial 880.8 ± 7.9 873.3 898.5 3.70 ± 0.04

Benchmark Results: Factorial - Recursive

Command Mean [s] Min [s] Max [s] Relative
revm_FactorialRecursive 1.442 ± 0.093 1.333 1.581 1.00
levm_FactorialRecursive 13.213 ± 0.197 13.004 13.450 9.16 ± 0.61

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Fibonacci 210.8 ± 0.5 210.1 211.6 1.00
levm_Fibonacci 878.0 ± 8.8 869.4 899.1 4.17 ± 0.04

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ManyHashes 8.7 ± 0.0 8.7 8.8 1.00
levm_ManyHashes 18.0 ± 0.7 17.5 19.9 2.06 ± 0.08

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
revm_BubbleSort 3.241 ± 0.021 3.210 3.279 1.00
levm_BubbleSort 5.779 ± 0.034 5.732 5.837 1.78 ± 0.02

Benchmark Results: ERC20 - Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Transfer 251.8 ± 2.0 249.3 256.4 1.00
levm_ERC20Transfer 508.3 ± 4.1 500.4 515.1 2.02 ± 0.02

Benchmark Results: ERC20 - Mint

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Mint 143.4 ± 0.9 142.4 145.0 1.00
levm_ERC20Mint 323.7 ± 4.1 316.9 329.6 2.26 ± 0.03

Benchmark Results: ERC20 - Approval

Command Mean [s] Min [s] Max [s] Relative
revm_ERC20Approval 1.056 ± 0.045 1.038 1.183 1.00
levm_ERC20Approval 1.921 ± 0.014 1.894 1.945 1.82 ± 0.08

Main Results

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Factorial 239.5 ± 0.8 238.5 241.0 1.00
levm_Factorial 881.1 ± 13.1 872.6 916.6 3.68 ± 0.06

Benchmark Results: Factorial - Recursive

Command Mean [s] Min [s] Max [s] Relative
revm_FactorialRecursive 1.401 ± 0.087 1.338 1.588 1.00
levm_FactorialRecursive 13.086 ± 0.114 12.971 13.387 9.34 ± 0.58

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Fibonacci 213.4 ± 2.1 209.6 215.4 1.00
levm_Fibonacci 906.3 ± 83.0 868.7 1139.9 4.25 ± 0.39

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ManyHashes 8.8 ± 0.1 8.7 8.9 1.00
levm_ManyHashes 17.9 ± 0.3 17.5 18.3 2.05 ± 0.04

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
revm_BubbleSort 3.256 ± 0.018 3.231 3.293 1.00
levm_BubbleSort 5.765 ± 0.031 5.719 5.805 1.77 ± 0.01

Benchmark Results: ERC20 - Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Transfer 249.3 ± 0.7 248.7 251.0 1.00
levm_ERC20Transfer 506.0 ± 4.1 499.8 512.6 2.03 ± 0.02

Benchmark Results: ERC20 - Mint

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Mint 142.9 ± 1.1 140.6 144.5 1.00
levm_ERC20Mint 320.6 ± 3.0 316.3 325.5 2.24 ± 0.03

Benchmark Results: ERC20 - Approval

Command Mean [s] Min [s] Max [s] Relative
revm_ERC20Approval 1.040 ± 0.011 1.031 1.062 1.00
levm_ERC20Approval 1.928 ± 0.015 1.905 1.954 1.85 ± 0.02

Copy link

github-actions bot commented Apr 29, 2025

EF Tests Comparison

Test Name MAIN PR DIFF
Summary: 32725/38385 (85.25%) 18910/18910 (100.00%) ⬆️ -13815
Prague: 5202/5202 (100.00%) 5202/5202 (100.00%) ➖️
Cancun: 7608/7608 (100.00%) 7608/7608 (100.00%) ➖️
Shanghai: 3214/3214 (100.00%) 3214/3214 (100.00%) ➖️
Paris: 2886/2886 (100.00%) 2886/2886 (100.00%) ➖️
London: 2870/2915 (98.46%) 0/0 (NaN%) ➖️ -2870
Berlin: 215/2755 (7.80%) 0/0 (NaN%) ➖️ -215
Istanbul: 238/2709 (8.79%) 0/0 (NaN%) ➖️ -238
Petersburg: 2490/2564 (97.11%) 0/0 (NaN%) ➖️ -2490
Constantinople: 2312/2428 (95.22%) 0/0 (NaN%) ➖️ -2312
Byzantium: 2429/2492 (97.47%) 0/0 (NaN%) ➖️ -2429
SpuriousDragon: 567/598 (94.82%) 0/0 (NaN%) ➖️ -567
Tangerine: 570/669 (85.20%) 0/0 (NaN%) ➖️ -570
Homestead: 1354/1465 (92.42%) 0/0 (NaN%) ➖️ -1354
Frontier: 770/880 (87.50%) 0/0 (NaN%) ➖️ -770

@JereSalo JereSalo marked this pull request as ready for review April 29, 2025 21:23
@JereSalo JereSalo requested a review from a team as a code owner April 29, 2025 21:23
Copy link
Contributor

@SDartayet SDartayet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JereSalo JereSalo added this pull request to the merge queue May 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 5, 2025
@JereSalo JereSalo added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit 6ed8a1f May 6, 2025
35 checks passed
@JereSalo JereSalo deleted the levm/add_docs_forks branch May 6, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation levm Lambda EVM implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants