-
Notifications
You must be signed in to change notification settings - Fork 55
feat(l1): add eth to enr #2654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mechanix97
wants to merge
31
commits into
main
Choose a base branch
from
feat/add-eth-to-enr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(l1): add eth to enr #2654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
eth
pair was not implemented in the current node record struct.Using this information when trying to connect to a new peer, allow us to discard incompatible nodes faster
Description
The fork_id struct is constructed only once before the handling process starts
The
eth
pair contains a single element list, which is a ForkId element. It's encoded/decoded using the default RLP procedure.When exchanging the ENRrequest/ENRresponse messages the
eth
pair is includedIt can be tested starting a new node with debug level:
And connecting a new peer using the following command:
A debug msg can be seen once the
eth
pair is validatedETH enr entry
EIP-2124
Ethrex Docs
Closes #1799