Skip to content

feat(l2): bench job #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
May 12, 2025
Merged

feat(l2): bench job #2663

merged 36 commits into from
May 12, 2025

Conversation

xqft
Copy link
Contributor

@xqft xqft commented May 2, 2025 •
edited
Loading

Motivation

Continously (on each push to main) prove an Ethereum Mainnet block to test and benchmark ethrex-prover.

Description

  • adds job to prove an L1 block using the bench crate
  • post the gas rate (Mgas/s) into gh pages with the github benchmark action.

@xqft xqft requested a review from a team as a code owner May 2, 2025 19:53
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2025 •
edited
Loading

Lines of code report

Total lines added: 38
Total lines removed: 0
Total lines changed: 38

Detailed view 
+-------------------------------------------+-------+------+
| File                                      | Lines | Diff |
+-------------------------------------------+-------+------+
| ethrex/crates/l2/prover/bench/src/main.rs | 133   | +38  |
+-------------------------------------------+-------+------+

@xqft
Copy link
Contributor Author

xqft commented May 2, 2025 •
edited
Loading

Successful run: https://github.com/lambdaclass/ethrex/actions/runs/14803522566/job/41567485293

TODO:

  1. Add ETHREX_L2_RPC_URL secret
  2. Add system info about runner

Base automatically changed from l2/fix_bench_2 to l2/bump_sp1 May 5, 2025 14:27
@xqft
Copy link
Contributor Author

xqft commented May 5, 2025

Another option is to cache a block, but in that case we would be omitting part of the flow and we may not catch some bugs

Base automatically changed from l2/bump_sp1 to main May 5, 2025 15:26
@xqft
Copy link
Contributor Author

xqft commented May 6, 2025

Successful run: https://github.com/lambdaclass/ethrex/actions/runs/14862115771/job/41729453553?pr=2663

@xqft xqft mentioned this pull request May 6, 2025
Open
LeanSerra
LeanSerra approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@LeanSerra LeanSerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For now its better not to use RPC and use the cached block as most networks are on Electra

@xqft xqft enabled auto-merge May 12, 2025 13:55
@xqft xqft added this pull request to the merge queue May 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 12, 2025
@xqft xqft added this pull request to the merge queue May 12, 2025
@jrchatruc jrchatruc removed this pull request from the merge queue due to a manual request May 12, 2025
@jrchatruc jrchatruc added this pull request to the merge queue May 12, 2025
Merged via the queue into main with commit 897af4f May 12, 2025
30 checks passed
@jrchatruc jrchatruc deleted the l2/bench_job branch May 12, 2025 18:23
fmoletta pushed a commit that referenced this pull request May 15, 2025
@xqft @fmoletta
feat(l2): bench job (#2663)
731975d 
**Motivation**

Continously (on each push to main) prove an Ethereum Mainnet block to
test and benchmark ethrex-prover.

**Description**

- adds job to prove an L1 block using the `bench` crate
- post the gas rate (Mgas/s) into gh pages with the github benchmark
action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iovoid iovoid iovoid approved these changes

@LeanSerra LeanSerra LeanSerra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xqft @iovoid @LeanSerra @jrchatruc