feat: integrate MemWAL for context storage #36
Merged
Conversation
Collaborator
Author
|
Here is the verified directory structure created by the MemWAL integration during manual testing: |
beinan
changed the title
beinan
force-pushed
the
feat/memwal-integration
branch
from
cab6381 to
f496535
Compare
beinan
changed the title
- Update dependencies to use lance/main for MemWAL support. - Enable MemWAL in `ContextStore::add` using `RegionWriter`. - Implement deterministic `region_id` generation based on `bot_id` and `session_id`. - Add `lance-schema:unenforced-primary-key` metadata to schema. Co-authored-by: Cursor <cursoragent@cursor.com>
- Fix TC003 in python/tests/test_compaction.py (move Path import to TYPE_CHECKING). - Apply cargo fmt to crates/lance-context-core/src/store.rs. - Apply ruff formatting to python tests. Co-authored-by: Cursor <cursoragent@cursor.com>
beinan
force-pushed
the
feat/memwal-integration
branch
from
f496535 to
fabe155
Compare
- Wrap long line for cargo fmt compliance - Fix lance-namespace version to 0.7.7 (pylance 7.0.0 requires <0.8) Co-Authored-By: Beinan Wang <beinanwang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates MemWAL (Memory Table & Write-Ahead Log) into
ContextStoreto improve write performance and data consistency.Changes
lance,lance-namespace, andlance-indexto point tomainbranch to access MemWAL APIs.RegionWriterinContextStore::add.region_idgeneration using UUID v5 based onbot_idandsession_id.lance-schema:unenforced-primary-keymetadata to theidfield in the schema.store.rstests. Note: Some assertions are temporarily commented out asDataset::scandoes not yet transparently read MemWAL data (requiresLsmScannerintegration).Verification
_mem_waldirectory and correct file structure.Made with Cursor