fix: delete using _rowaddr incorrectly applied to all fragments #118
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
qidian99
changed the title
fangbo
reviewed
Nov 20, 2025
|
|
||
| @Override | ||
| public void delete(InternalRow metadata, InternalRow id) throws IOException { | ||
| long rowAddr = id.getLong(0); |
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Although this modification can workaround this problem, I think it's tricky and confusable. Theoretically, the metadata and id should belong to the same row. Which means that they belong to the same Fragment.
I think we also should fix the Fragment.scan's wrong results with filter _rowaddr == 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #117