chore: create a delta index to cover the unindexed fragments#1802
Closed
chore: create a delta index to cover the unindexed fragments#1802
Conversation
eddyxu
force-pushed
the
lei/merge_pq_code
branch
from
8fee64a to
5d940b5
Compare
eddyxu
changed the title
rust/lance-index/src/optimize.rs
Outdated
| pub struct MergeIndex {} | ||
|
|
||
| pub enum OptimizeAction { | ||
| Append, |
Contributor
There was a problem hiding this comment.
should we just make CreateDelta a mode of Append? say Append(create_new_fragment)
Member
Author
There was a problem hiding this comment.
Lemme think about it. The intent was that one would not merge with the previous index, and the other would merge with the previous index.
Member
Author
There was a problem hiding this comment.
Probally we just have one option to determine how many previous index to be merged together?
eddyxu
force-pushed
the
lei/merge_pq_code
branch
from
2aaf9f0 to
4ea5224
Compare
eddyxu
force-pushed
the
lei/merge_pq_code
branch
from
4ea5224 to
41f62e4
Compare
Member
Author
|
Close in favor of #1841 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.