feat: relax enabled features on lance #242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disables default feature from lance. The current set of default features pulls in crates needed for cloud support (aws-*, gcp) which are not technically needed for lance-namespace.
This had `rustls-tls-native-roots` hardcoded for reqwest. Users of aws-* crates might want to use `rustls-tls-native-roots-no-provider` instead, as that uses aws-lc-rs over ring.
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
valkum
changed the title
This was referenced Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #240 for more details.
TL;DR:
lance-namespacedepends onlancewith default features, which pulls in a lot ofaws-*crates that are not needed forlance-namespace.lance-namespacealso enabledringforreqwestand some aws-crates could enableaws-lc-rs, requiring users to set a default provider forrustlsin their binaries.Solution
This resolves the issue of pulled in
aws-*crates by removing default features fromlance.The
rustlsprovider issue is fixed by allowing users oflance-namespaceto select which feature is enabled forreqwest. The current default is preserved via the default feature.Closes #240