Skip to content

fix: set finish before notifying load in LanceArrowWriter setFinished method #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: set finish before notifying load in LanceArrowWriter setFinished method #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lance-spark-base_2.12/src/main/java/com/lancedb/lance/spark/write/LanceArrowWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class LanceArrowWriter extends ArrowReader {
private final int batchSize;

@GuardedBy("monitor")
private volatile boolean finished;
private volatile boolean finished = false;

private final AtomicLong totalBytesRead = new AtomicLong();
private com.lancedb.lance.spark.arrow.LanceArrowWriter arrowWriter = null;
Expand Down Expand Up @@ -70,8 +70,8 @@ void write(InternalRow row) {
}

void setFinished() {
loadToken.release();
finished = true;
loadToken.release();
}

@Override
Expand Down
3 changes: 0 additions & 3 deletions lance-spark-base_2.12/src/test/java/com/lancedb/lance/spark/write/LanceArrowWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import org.apache.spark.sql.types.DataTypes;
import org.apache.spark.sql.types.StructField;
import org.apache.spark.sql.types.StructType;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import java.util.Collections;
Expand All @@ -35,8 +34,6 @@

import static org.junit.jupiter.api.Assertions.assertEquals;

// TODO: Flaky in CI, needs to fix
@Disabled
public class LanceArrowWriterTest {
@Test
public void test() throws Exception {
Expand Down