Skip to content

fix: rebuild supported Pantheon appservers on patched PHP images - #373

Merged
AaronFeledy merged 8 commits into
mainfrom
fix/php-cve-2026-10
Nov 16, 2026
Merged

AaronFeledy merged 8 commits into
mainfrom
fix/php-cve-2026-10

Conversation

@AaronFeledy

@AaronFeledy AaronFeledy commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Summary

Do not merge this until the lando/php -7 tags on Docker Hub are verified at or above the Oct 2026 security floors. Opening it early makes the 8.2–8.5 -edge builds fail the version check on purpose, because today's -7 images are still the June builds.

Supported Pantheon appservers move off the frozen Nov 2025 bases:

  • 8.2–8.5 FROM devwithlando/php:X.Y-fpm-7 instead of -5
  • Same version floor as the php images (8.2.35, 8.3.36, 8.4.27, 8.5.12), so a stale base fails before push
  • 8.3/8.4/8.5 install openjdk-21-jre-headless. Those -7 images are Debian trixie, which does not ship OpenJDK 17. 8.2 stays on bookworm and keeps OpenJDK 17
  • Appserver tags stay at -5. No plugin release. 8.1 and older stay on fpm-5 and stay unpatched
  • pull: true on the image workflow

This is a Debian major bump for 8.3–8.5 (bookworm to trixie), not just a PHP patch. The -edge build is where ImageMagick/Tika/Java 21 either works or doesn't. A red EOL or Solr job on main is not this fix failing. fail-fast is already false.

Users get the new appserver with lando rebuild, not lando start.

Depends on lando/php#255. Merge that, wait for the production -7 tags to verify, then merge this.

Test plan

  • Do not merge before the eight devwithlando/php -7 tags verify
  • -edge appservers for 8.2–8.5 report PHP_VERSION at or above the floor, both arches
  • Tika still runs on Java 21 in the 8.3/8.4/8.5 -edge images
  • 8.1 and older appserver tags are not described as patched

Note

Medium Risk
Changes published runtime bases (Debian trixie, Java 21) and build gates for supported PHP versions; depends on upstream lando/php -7 tags before merge is safe.

Overview
Rebases PHP 8.2–8.5 Pantheon appserver images on devwithlando/php:*-fpm-7 and fails the build when the base’s PHP_VERSION is below enforced floors (MIN_PHP in CI via build-pantheon-images.yml). 8.3–8.5 switch to OpenJDK 21 for Debian trixie bases; 7.3–8.0 Dockerfiles repoint apt/MariaDB mirrors to archives so EOL images can still install packages.

CI and validation: image builds set pull: true and pass per-version MIN_PHP. Integration Leia jobs drop the Lando-version matrix, run 3-stable then 3-edge serially per fixture (concurrency per fixture, staggered API sleep), require both to pass, pin Leia 1.0.0-beta.4, and add an explicit Destroy tests section in the init example. Unit tests use macos-15-intel. Docs update Pantheon token links; AGENTS.md and CHANGELOG note the image and workflow changes.

Reviewed by Cursor Bugbot for commit 7e09eb6. Bugbot is set up for automated code reviews on this repo. Configure here.

CI maintenance

Pinned the Leia action fallback to the existing lockfile version so its Node 18 runner does not install Node 24-only Leia 2. Restored bullseye archive package sources without disabling package signature verification. Updated the Pantheon token docs link to its canonical target, fixing the Netlify external-link redirect check. Supported appserver builds remain gated on PHP #255 publishing production bases first.

Local validation: lint and docs build passed; unit command passed (32 passing / 1 pending). Isolated setup/test/cleanup Leia smoke passed under Node 18.20.8. Full integration and multi-platform image validation are pending the new CI runs.

The integration jobs now serialize each shared remote fixture across stable/edge runners with a concurrency group; a short per-fixture delay still smooths API requests. A fixed five-minute delay did not prevent concurrent pushes from diverging the Drupal 10 remote.

8.2-8.5 appservers move from devwithlando/php:X.Y-fpm-5 to -7 and fail
the build below the Oct 2026 security floors. 8.3-8.5 switch to
OpenJDK 21 because those -7 bases are Debian trixie. EOL appservers
stay on the -5 PHP images.
@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for lando-pantheon ready!

Name Link
🔨 Latest commit 7e09eb6
🔍 Latest deploy log https://app.netlify.com/projects/lando-pantheon/deploys/6afb7671cbfe64f12eace0b1
😎 Deploy Preview https://deploy-preview-373--lando-pantheon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 8 from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

-e 's|deb.debian.org/debian-security|archive.debian.org/debian-security|g' /etc/apt/sources.list \
&& find /etc/apt/sources.list.d -name '*.list' -exec sed -i \
's|mirror.mariadb.org/repo/|archive.mariadb.org/repo/|g' {} + \
&& echo 'Acquire::Check-Valid-Until "false";' > /etc/apt/apt.conf.d/99ignore-release-date

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete Debian archive source rewrite

High Severity

The new apt rewrite only retargets debian-security URLs and MariaDB mirrors. Main and updates entries stay on deb.debian.org/debian, which no longer carries EOL bullseye/buster after LTS. apt-get update in these appserver builds can still 404, so the archive restore does not make the images rebuildable. The stretch 7.2 Dockerfile already replaces the whole sources.list with archive.debian.org.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit c4ef9b1. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6eff1b8. Configure here.

Comment thread .github/workflows/pr-pantheon-tests.yml Resolved
@AaronFeledy
AaronFeledy merged commit 5745318 into main Nov 16, 2026
53 of 58 checks passed
@AaronFeledy
AaronFeledy deleted the fix/php-cve-2026-10 branch November 16, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant