Repository navigation
fix: rebuild supported Pantheon appservers on patched PHP images - #373
Conversation
8.2-8.5 appservers move from devwithlando/php:X.Y-fpm-5 to -7 and fail the build below the Oct 2026 security floors. 8.3-8.5 switch to OpenJDK 21 because those -7 bases are Debian trixie. EOL appservers stay on the -5 PHP images.
✅ Deploy Preview for lando-pantheon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| -e 's|deb.debian.org/debian-security|archive.debian.org/debian-security|g' /etc/apt/sources.list \ | ||
| && find /etc/apt/sources.list.d -name '*.list' -exec sed -i \ | ||
| 's|mirror.mariadb.org/repo/|archive.mariadb.org/repo/|g' {} + \ | ||
| && echo 'Acquire::Check-Valid-Until "false";' > /etc/apt/apt.conf.d/99ignore-release-date |
There was a problem hiding this comment.
Incomplete Debian archive source rewrite
High Severity
The new apt rewrite only retargets debian-security URLs and MariaDB mirrors. Main and updates entries stay on deb.debian.org/debian, which no longer carries EOL bullseye/buster after LTS. apt-get update in these appserver builds can still 404, so the archive restore does not make the images rebuildable. The stretch 7.2 Dockerfile already replaces the whole sources.list with archive.debian.org.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit c4ef9b1. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6eff1b8. Configure here.



Summary
Do not merge this until the
lando/php-7tags on Docker Hub are verified at or above the Oct 2026 security floors. Opening it early makes the 8.2–8.5-edgebuilds fail the version check on purpose, because today's-7images are still the June builds.Supported Pantheon appservers move off the frozen Nov 2025 bases:
8.2–8.5FROM devwithlando/php:X.Y-fpm-7instead of-58.3/8.4/8.5installopenjdk-21-jre-headless. Those-7images are Debian trixie, which does not ship OpenJDK 17.8.2stays on bookworm and keeps OpenJDK 17-5. No plugin release. 8.1 and older stay onfpm-5and stay unpatchedpull: trueon the image workflowThis is a Debian major bump for 8.3–8.5 (bookworm to trixie), not just a PHP patch. The
-edgebuild is where ImageMagick/Tika/Java 21 either works or doesn't. A red EOL or Solr job onmainis not this fix failing.fail-fastis already false.Users get the new appserver with
lando rebuild, notlando start.Depends on lando/php#255. Merge that, wait for the production
-7tags to verify, then merge this.Test plan
devwithlando/php-7tags verify-edgeappservers for 8.2–8.5 reportPHP_VERSIONat or above the floor, both arches-edgeimagesNote
Medium Risk
Changes published runtime bases (Debian trixie, Java 21) and build gates for supported PHP versions; depends on upstream
lando/php-7tags before merge is safe.Overview
Rebases PHP 8.2–8.5 Pantheon appserver images on
devwithlando/php:*-fpm-7and fails the build when the base’sPHP_VERSIONis below enforced floors (MIN_PHPin CI viabuild-pantheon-images.yml). 8.3–8.5 switch to OpenJDK 21 for Debian trixie bases; 7.3–8.0 Dockerfiles repoint apt/MariaDB mirrors to archives so EOL images can still install packages.CI and validation: image builds set
pull: trueand pass per-versionMIN_PHP. Integration Leia jobs drop the Lando-version matrix, run 3-stable then 3-edge serially per fixture (concurrency per fixture, staggered API sleep), require both to pass, pin Leia1.0.0-beta.4, and add an explicit Destroy tests section in the init example. Unit tests usemacos-15-intel. Docs update Pantheon token links;AGENTS.mdandCHANGELOGnote the image and workflow changes.Reviewed by Cursor Bugbot for commit 7e09eb6. Bugbot is set up for automated code reviews on this repo. Configure here.
CI maintenance
Pinned the Leia action fallback to the existing lockfile version so its Node 18 runner does not install Node 24-only Leia 2. Restored bullseye archive package sources without disabling package signature verification. Updated the Pantheon token docs link to its canonical target, fixing the Netlify external-link redirect check. Supported appserver builds remain gated on PHP #255 publishing production bases first.
Local validation: lint and docs build passed; unit command passed (32 passing / 1 pending). Isolated setup/test/cleanup Leia smoke passed under Node 18.20.8. Full integration and multi-platform image validation are pending the new CI runs.
The integration jobs now serialize each shared remote fixture across stable/edge runners with a concurrency group; a short per-fixture delay still smooths API requests. A fixed five-minute delay did not prevent concurrent pushes from diverging the Drupal 10 remote.