Propagated context and remove use_span #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagkumar91
changed the title
Collaborator
|
LGTM and user validated the fix so going to merge! |
marlenezw
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On drop_use_span we ripped out the tracer’s
use_span()/ContextVarhandling that caused async FastAPI calls to crash, then taught the tracer to rebuild LangGraph parent-child relationships explicitly: _start_span now accepts thread metadata, records aper-thread agent stack, and falls back to that stack (or thread root) when LangChain omits parent_run_id, ensuring nested agents, chats, and tools attach correctly. We added new tests to cover thread-root fallback plus stack behavior, reproduced the
ContextVar and hierarchy issues via local FastAPI/LangGraph samples, then reran the tracer unit suite and key samples after each change.
Addresses #212