Skip to content

Conversation

@pokey
Copy link
Contributor

@pokey pokey commented Oct 23, 2025

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2025

⚠️ No Changeset found

Latest commit: 23db393

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

}

console.log("\n=== Agent with human-in-the-loop completed ===\n");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a comment section showing the complete expected output? It would makes it easier for folks to see what the example results without having to set up the project.

- Casting to the correct data type
- Using the proper columns for joins

If there are any of the above mistakes, rewrite the query. If there are no mistakes,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideal to send rejection and reason back to generate_query so this node remains purely a reviewer?

@hntrl hntrl merged commit 18abe1e into langchain-ai:main Nov 3, 2025
15 checks passed
lnhsingh added a commit to langchain-ai/docs that referenced this pull request Nov 6, 2025
Just translates the Python version of the langgraph sql-agent tutorial
to js.

- Depends on langchain-ai/langchainjs#9228
- See also langchain-ai/langgraphjs#1750

---------

Co-authored-by: Hunter Lovell <[email protected]>
Co-authored-by: Hunter Lovell <[email protected]>
Co-authored-by: Lauren Hirata Singh <[email protected]>
Co-authored-by: Christian Bromann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants