Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the error of unable to retrieve url from file #10513

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

XiaoLey
Copy link
Contributor

@XiaoLey XiaoLey commented Nov 11, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes #10514
Close #10590

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 11, 2024
@XiaoLey
Copy link
Contributor Author

XiaoLey commented Nov 12, 2024

cc @laipz8200 @crazywoola

@skywalkerfmc
Copy link

cc @laipz8200 @crazywoola

这样只能获取到那个签名url吧,通过这个url获取不到原始数据

@XiaoLey
Copy link
Contributor Author

XiaoLey commented Nov 12, 2024 via email

@skywalkerfmc
Copy link

Are you saying the generated signature URL isn't working? I'll take a look at it later.

________________________________ 发件人: skywalkerfmc @.> 发送时间: 2024年11月12日 9:17 收件人: langgenius/dify @.> 抄送: Xiao Ley @.>; Author @.> 主题: Re: [langgenius/dify] fix the error of unable to retrieve url from file (PR #10513) cc @laipz8200https://github.com/laipz8200 @crazywoolahttps://github.com/crazywoola 这样只能获取到那个签名url吧,通过这个url获取不到原始数据 ― Reply to this email directly, view it on GitHub<#10513 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALBBFFPBTC377XWNTFX2X2T2AHBRPAVCNFSM6AAAAABRQ2MZD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZHE4DSOBRGA. You are receiving this because you authored the thread.Message ID: @.***>

Yes, I think the signature URL is invalid
screenshot-20241112-175144

@XiaoLey
Copy link
Contributor Author

XiaoLey commented Nov 12, 2024

这样只能获取到那个签名url吧,通过这个url获取不到原始数据

I just conducted a thorough test, and both user-uploaded files and tool-generated files can be accessed normally. Even using curl, the file data can be retrieved successfully. The image is shown below:

Snipaste_2024-11-12_17-50-12

Snipaste_2024-11-12_17-51-52

Snipaste_2024-11-12_17-52-43

Snipaste_2024-11-12_17-52-54


Yes, I think the signature URL is invalid

You can take a look at this environment variable: FILES_URL

image


In case there are any issues, please feel free to point them out! 😊

@skywalkerfmc
Copy link

这样只能获取到那个签名url吧,通过这个url获取不到原始数据

I just conducted a thorough test, and both user-uploaded files and tool-generated files can be accessed normally. Even using curl, the file data can be retrieved successfully. The image is shown below:我刚刚进行了一次彻底的测试,用户上传的文件和工具生成的文件都可以正常访问。即使使用 curl,也可以成功检索文件数据。该图如下所示:

Snipaste_2024-11-12_17-50-12

Snipaste_2024-11-12_17-51-52

Snipaste_2024-11-12_17-52-43

Snipaste_2024-11-12_17-52-54

Yes, I think the signature URL is invalid

You can take a look at this environment variable: FILES_URL

image

In case there are any issues, please feel free to point them out! 😊如果有任何问题,请随时指出来!😊

Does FILES_URL have to be set to "http://127.0.0.1:5001" . When I set to "http://127.0.0.1:5001", is don't work

@XiaoLey
Copy link
Contributor Author

XiaoLey commented Nov 12, 2024

@skywalkerfmc is it working now?

@skywalkerfmc
Copy link

@skywalkerfmc is it working now?

no, I deployed dify using docker. How should I set the FILES_URL

@xs818818
Copy link

how time merging

@laipz8200
Copy link
Collaborator

laipz8200 commented Nov 14, 2024

Let's have a discussion in #10687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: The url output by the list_operator is null fix the error of unable to retrieve url from file
4 participants