Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions to Matpower Format Parsing #53

Merged
merged 13 commits into from
Dec 8, 2016
Merged

Extensions to Matpower Format Parsing #53

merged 13 commits into from
Dec 8, 2016

Conversation

ccoffrin
Copy link
Member

@ccoffrin ccoffrin commented Dec 4, 2016

This pull request addresses the need to get non-standard data into PowerModels. It extends the Matpower parser to support a range of user extensions.

Documentation of these new features is provided in a new DATA.md file

This PR will close #49

@codecov-io
Copy link

codecov-io commented Dec 4, 2016

Current coverage is 87.92% (diff: 91.60%)

Merging #53 into master will increase coverage by 0.28%

@@             master        #53   diff @@
==========================================
  Files            20         20          
  Lines          1902       2013   +111   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1667       1770   +103   
- Misses          235        243     +8   
  Partials          0          0          

Powered by Codecov. Last update 5954a1e...f1a1fb0

@ccoffrin
Copy link
Member Author

ccoffrin commented Dec 5, 2016

Hey guys, I could use some input on this. Both conceptual feedback and nitty gritty Julia implementation stuff. There are some ugly hacks in there (e.g. see build_typed_dict, split_line), there should be a better way.

@rb004f @kersulis @kaarthiksundar @mlubin @bluejuniper @MowenLu

@rb004f
Copy link
Collaborator

rb004f commented Dec 5, 2016

The bigger question is how much matpower extension support do we want to provide? The json format is the standard, plus the ability to import other formats, like matpower... Unless there is a huge demand for extending Matpower, maybe the solution is to convert matpower to json, and then add extra data there?

@ccoffrin
Copy link
Member Author

ccoffrin commented Dec 5, 2016

@rb004f, this is a good point. So far, I have had requests from @kaarthiksundar, @bluejuniper, and @MowenLu to be able to get extra data into PowerModels from an extended Matpower file. Given our current user base, that feels like a "huge demand" to me. This was my motivation for adding this feature.

Recently, I have also been observing that the raw text of large JSON files is not easy for humans to read, comprehend, or edit. One needs a JSON viewer and/or a custom viewer, like the one I developed for the GRG JSON format, to understand the data. In contrast, it is easy for people to read and debug small-ish matrixes in the Matpower format.

Also, I would not want to rally the community around PowerModel's current JSON format. For me its really a internal thing, which can also be used for data exchange between algorithms. If we are going to have a new network data standard, I would prefer something more wholistic, like GRG. For now, I see Matpower as the standard data exchange format for research, hence we should have good support for it. In time, I hope we can transition to something better, but until then, I think we should have good support for Matpower data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More Robust String Parsing in Matpower Files
3 participants