Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate message when deactivating isolated components #943

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

Robbybp
Copy link
Contributor

@Robbybp Robbybp commented Feb 13, 2025

Was confused by this message so I updated it to more accurately reflect the logic.

@ccoffrin
Copy link
Member

Change looks good, can you add a note to the change log, then merge into master?

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.71%. Comparing base (8824212) to head (9c9e295).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #943   +/-   ##
=======================================
  Coverage   93.71%   93.71%           
=======================================
  Files          43       43           
  Lines        9636     9636           
=======================================
  Hits         9030     9030           
  Misses        606      606           
Files with missing lines Coverage Δ
src/core/data.jl 90.81% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8824212...9c9e295. Read the comment docs.

@odow odow merged commit db58c4f into lanl-ansi:master Mar 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants