Skip to content

Conversation

@chinmaypurav
Copy link

This pull request updates the README.md file to include instructions for ignoring local configuration files in version control. This helps prevent accidental commits of user-specific or sensitive configuration.

Documentation improvements:

  • Added instructions to add /.junie and .mcp.json to the .gitignore file to prevent committing local configuration files.

@pushpak1300
Copy link
Member

This one’s a bit tricky. Some agents support absolute paths, while others need full paths. If you’re using absolute paths, it makes sense to commit the .mcp.json file. But if you’re using full paths, committing it doesn’t make sense it really depends on your setup and the agents you’re using.

Since there’s no sensitive info in the config, I’m not convinced this change is needed right now. I’ll hold off merging it until we have a bit more discussion/thoughts around it.

Thanks again for the PR!

@pushpak1300 pushpak1300 marked this pull request as draft October 23, 2025 08:08
@chinmaypurav
Copy link
Author

This one’s a bit tricky. Some agents support absolute paths, while others need full paths. If you’re using absolute paths, it makes sense to commit the .mcp.json file. But if you’re using full paths, committing it doesn’t make sense it really depends on your setup and the agents you’re using.

Since there’s no sensitive info in the config, I’m not convinced this change is needed right now. I’ll hold off merging it until we have a bit more discussion/thoughts around it.

Thanks again for the PR!

There is no sensitive info in the config files, just the paths as per my local environment; so ideally these files should not be committed to git.

As you said, it depends as per individual needs, can we write it like something generic? Like some files do adapt to your local environment, so these files needs to be added to .gitignore? This is more like a caution before the devs commit all touched files. Let me know your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants