[13.x] Check traits in resolveClassAttribute #60566
Draft
jackbayliss wants to merge 4 commits into
Draft
Conversation
Matches queues etc.
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the exact same as I did here #60519
This means queue attributes 🤝 model attributes (We are same same but different)
This essentially means, traits can carry model attributes which means we can put attributes on a trait, and reuse the trait.
This only checks traits on the current class in the hierarchy same as the other PR
Nice for package maintainers, or teams using traits.
I'm completely fine if you close this, just thought I'd try bring the same behaviour as queues to models for the attributes 🫡