[13.x] Add memory usage to WorkerStopping#60613
Draft
jackbayliss wants to merge 4 commits into
Draft
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
$memoryUsage(in MB) to theWorkerStoppingevent so you can see the actual usage at the point the worker decided to stop, which is helpful for--memoryadjustments, and observability. I've also put the logic into a method cos it was getting duplicatedThis is useful as you can see your workers restart and the WorkerStopReason tells you it's memory related, but you don't actually know what the memory usage was.
Cloud does give cool metrics, but they give you clusters level metrics.
I have a bunch of cool ideas, that include drilling down into individual Worker metrics which this PR helps either way and reveals it for us to log and see :)
Thanks! Any feedback let me know.