[13.x] Add assertEmpty to the Storage facade#60658
Draft
jackbayliss wants to merge 1 commit into
Draft
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, asserting the whole disk is empty requires passing an empty string to assertDirectoryEmpty which reads oddly / feels a bit like a hack.
This PR adds an
assertEmptymethod, which is fully recursive, so it fails if a file exists anywhere on the disk.We have a lot of tests that set specific disks up, and we need to make sure they're empty ie certain files are moved / deleted etc via jobs, commands, etc...
I can macro it worst case, but feels like something everyone may benefit from.
Perhaps you prefer
assertDiskEmpty- so open to changing!