Improve performance of setting multiple feature values at once #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
commented
Nov 26, 2025
| ->map(fn ($bits) => ['feature' => $bits[0], 'scope' => $bits[1], 'value' => $value]) | ||
| ->all(); | ||
|
|
||
| $this->driver->setAll($features); |
Member
Author
There was a problem hiding this comment.
$this->driver is our decorator which implements the new contract, so calling setAll here is safe.
timacdonald
commented
Nov 26, 2025
| ->map(fn ($bits) => ['feature' => $bits[0], 'scope' => $bits[1], 'value' => false]) | ||
| ->all(); | ||
|
|
||
| $this->driver->setAll($features); |
Member
Author
There was a problem hiding this comment.
$this->driver is our decorator which implements the new contract, so calling setAll here is safe.
timacdonald
commented
Nov 26, 2025
| /** | ||
| * Set multiple feature flag values. | ||
| * | ||
| * @internal |
Member
Author
There was a problem hiding this comment.
Marked as internal so it doesn't show up on the Facade. This isn't meant to be called directly by the consuming application.
timacdonald
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the great work done in #156 by @nandi95
Adds support for an optional new contract that allows for more efficient batch updates.
Our first party drivers implement the driver by default.