Skip to content

Migration to Unsplash API #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Nov 1, 2024
Merged

Conversation

tauseefsshah
Copy link
Contributor

This PR fixes #1085
Adding the tests to this PR then it will be gtg

@tauseefsshah
Copy link
Contributor Author

Hi @driesvints

Please review this PR and lmk if the approach looks good. In the meantime I'll add the tests.

@driesvints
Copy link
Member

Hi @tauseefsshah. This looks really good! Thank you so much for working on this.

It seems we'll need to do a couple of more steps before we're production ready. Would it be possible to place the following below every photo on the article itself (not on the preview photos on the homepage). This can be an xs-text.

Photo by Annie Spratt on Unsplash

We should also save the author name and link to their unsplash profile in the database.

@driesvints
Copy link
Member

Screenshot 2024-10-02 at 08 30 51

@tauseefsshah
Copy link
Contributor Author

Hi @driesvints Thank you and you're welcome!

Sure I will add the text with the links.

One quick query, should I just create a json column for this which will store the image_url, author_name and author_profile_url or store the data in separate columns?

@driesvints
Copy link
Member

Storing in separate columns is fine 👍

@tauseefsshah
Copy link
Contributor Author

Hi @driesvints, Have added the attributes below the image.

image

@tauseefsshah
Copy link
Contributor Author

This PR introduces the following changes in the db:

  • Renames the column hero_image to hero_image_id for better verbosity
  • Add columns hero_image_url, hero_image_author_name and hero_image_author_url

@driesvints
Copy link
Member

Amazing work 👏

I've adjusted a few things and applied for production access. As soon as that's approved I'll deploy the PR.

@driesvints
Copy link
Member

Still waiting on Unsplash btw. Will get back here once I have something to share.

@tauseefsshah
Copy link
Contributor Author

Thanks for sharing the updates
It takes this long for production access 🤯

@driesvints driesvints merged commit 136eae8 into laravelio:main Nov 1, 2024
1 check passed
@driesvints
Copy link
Member

Finally gotten production access. Thanks a bunch for this one!

@tauseefsshah tauseefsshah deleted the fix/unsplash-api branch November 1, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Unsplash API
2 participants