-
-
Notifications
You must be signed in to change notification settings - Fork 659
Migration to Unsplash API #1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @driesvints Please review this PR and lmk if the approach looks good. In the meantime I'll add the tests. |
Hi @tauseefsshah. This looks really good! Thank you so much for working on this. It seems we'll need to do a couple of more steps before we're production ready. Would it be possible to place the following below every photo on the article itself (not on the preview photos on the homepage). This can be an
We should also save the author name and link to their unsplash profile in the database. |
Hi @driesvints Thank you and you're welcome! Sure I will add the text with the links. One quick query, should I just create a json column for this which will store the |
Storing in separate columns is fine 👍 |
Hi @driesvints, Have added the attributes below the image. |
This PR introduces the following changes in the db:
|
Amazing work 👏 I've adjusted a few things and applied for production access. As soon as that's approved I'll deploy the PR. |
Still waiting on Unsplash btw. Will get back here once I have something to share. |
Thanks for sharing the updates |
Finally gotten production access. Thanks a bunch for this one! |
This PR fixes #1085
Adding the tests to this PR then it will be gtg