misc: Update to FFmpeg@8.1#251
Open
ldm0 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the default FFmpeg branch used by the platform build helper scripts and expands CI coverage to include FFmpeg release/8.1.
Changes:
- Bump the default FFmpeg git branch from
release/8.0torelease/8.1in the Linux/macOS/Windows FFmpeg build scripts. - Add
release/8.1to the GitHub Actions CI matrix and ensure it is part of the “should_test” nightly set and feature-flag mapping.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| utils/windows_ffmpeg.rs | Update default FFmpeg branch argument to release/8.1 for Windows build helper. |
| utils/mac_ffmpeg.rs | Update default FFmpeg branch argument to release/8.1 for macOS build helper. |
| utils/linux_ffmpeg.rs | Update default FFmpeg branch argument to release/8.1 for Linux build helper. |
| .github/workflows/ci.yml | Add release/8.1 to CI matrix and feature-flag mapping; extend nightly test coverage list. |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:138
- The exclude comment says “Only run valgrind with latest FFmpeg”, but valgrind isn’t excluded for
release/7.1orrelease/8.0(and nowrelease/8.1is the latest). Either update the exclude list to keep valgrind limited to the single latest version, or adjust the comment so it reflects the actual matrix behavior.
exclude:
# Only run valgrind with latest FFmpeg and stable rust toolchain to reduce resource consumption.
# valgrind starts to fail on nightly toolchain due to a bug in std: https://github.com/rust-lang/rust/issues/135608
- valgrind: "valgrind"
ffmpeg-version: "release/6.0"
- valgrind: "valgrind"
ffmpeg-version: "release/6.1"
- valgrind: "valgrind"
ffmpeg-version: "release/7.0"
- valgrind: "valgrind"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.