Skip to content

misc: Update to FFmpeg@8.1#251

Open
ldm0 wants to merge 1 commit into
larksuite:masterfrom
ldm0:ffmpeg_8_1
Open

misc: Update to FFmpeg@8.1#251
ldm0 wants to merge 1 commit into
larksuite:masterfrom
ldm0:ffmpeg_8_1

Conversation

@ldm0

@ldm0 ldm0 commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@ldm0 ldm0 requested a review from Copilot April 10, 2026 18:48
@CLAassistant

CLAassistant commented Apr 10, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the default FFmpeg branch used by the platform build helper scripts and expands CI coverage to include FFmpeg release/8.1.

Changes:

  • Bump the default FFmpeg git branch from release/8.0 to release/8.1 in the Linux/macOS/Windows FFmpeg build scripts.
  • Add release/8.1 to the GitHub Actions CI matrix and ensure it is part of the “should_test” nightly set and feature-flag mapping.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
utils/windows_ffmpeg.rs Update default FFmpeg branch argument to release/8.1 for Windows build helper.
utils/mac_ffmpeg.rs Update default FFmpeg branch argument to release/8.1 for macOS build helper.
utils/linux_ffmpeg.rs Update default FFmpeg branch argument to release/8.1 for Linux build helper.
.github/workflows/ci.yml Add release/8.1 to CI matrix and feature-flag mapping; extend nightly test coverage list.
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:138

  • The exclude comment says “Only run valgrind with latest FFmpeg”, but valgrind isn’t excluded for release/7.1 or release/8.0 (and now release/8.1 is the latest). Either update the exclude list to keep valgrind limited to the single latest version, or adjust the comment so it reflects the actual matrix behavior.
        exclude:
          # Only run valgrind with latest FFmpeg and stable rust toolchain to reduce resource consumption.
          # valgrind starts to fail on nightly toolchain due to a bug in std: https://github.com/rust-lang/rust/issues/135608
          - valgrind: "valgrind"
            ffmpeg-version: "release/6.0"
          - valgrind: "valgrind"
            ffmpeg-version: "release/6.1"
          - valgrind: "valgrind"
            ffmpeg-version: "release/7.0"
          - valgrind: "valgrind"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread utils/linux_ffmpeg.rs
Comment thread utils/mac_ffmpeg.rs
Comment thread utils/windows_ffmpeg.rs
Comment thread .github/workflows/ci.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants