Skip to content

small changes #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

small changes #49

wants to merge 46 commits into from

Conversation

ashraf-kx
Copy link

  • Supporting QT6
  • Can be used in CMake project
  • Moving all widgets inside a namespace called "md"
  • Muted the button issue related to high usage of CPU

@Razzile
Copy link

Razzile commented Jun 24, 2022

can widgets be used inside namespaces? I thought that caused issues with moc.

Also I think this project is abandoned unfortunately. I'd consider maintaining your own fork if you receive no response here

@redtide
Copy link

redtide commented Nov 25, 2023

can widgets be used inside namespaces? I thought that caused issues with moc.

I'm about to fork this project and I think I'll remove all those "qtmaterial" prefixes in files and names, and use some qmw namespace instead, similar to what I did in my "SmartWidgets" project.

immagine

@redtide
Copy link

redtide commented Nov 25, 2023

BTW this PR is something I would never merge if I were the maintainer, there are too many changes in a single place, you should make only one for CMake and other fixes in separated PR. It's an overkill to review.

I see a lot of PR around like this, and all almost unmerged, sometimes even without a single comment from the maintainer. Does people still have some empathy and/or good sense?
If were yours, would you really merge something like this from another person to completely upset your project, even if correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants