Hotfix for weird heavy quark residual behavior during MG setup #1324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entally fixed in feature/cheby-mg-setup already but in a broader commit so it cannot be cherry picked easily
weinbe2
assigned
maddyscientist and
kostrzewa and unassigned
maddyscientist and
kostrzewa
maddyscientist
approved these changes
Sep 19, 2022
Member
maddyscientist
left a comment
maddyscientist
left a comment
There was a problem hiding this comment.
Do you know when this issue was introduced? For posterity, it would be good to document when.
Regardless: approved
Member
|
Looks likely to be 3ab9b4e |
mathiaswagner
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This narrow PR is a hotfix for the issue reported in #1323. I had hit this issue previously and fixed it in #1283 (which has not yet been merged), commit f954cec . I assumed, at the time, that the need for that fix was related to my other changes in MG setup and not something already lurking in
develop(or maybe something introduced since then), which is why I didn't make a hotfix branch in the first place.That commit is much bigger than just the narrow heavy quark residual fix so it can't just be "cherry-pick"ed out.
While this issue appearing is indeed weird, I think the logic of the fix is reasonable, so I don't see a need to investigate it more deeply at this time.