Feature/reproducible #1446
Open
Feature/reproducible #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reduction type is changed
… legacy zero helper function
…ternal computation
…oduce new CMake set types: real_t (QUDA_SCALAR_TYPE) - the host side scalar precision, complex_t the complex version of this (replaces Complex), device_reduce_t (QUDA_REDUCTION_TYPE). Eventually we will be able to set these to non-double types, but we're there yet....
…educe_t are different types, e.g., double vs doubledouble
… a different type (needed when copying from deviation_t<doubledouble> to deviation_t<double> for example
…ble (need to split into 64-bit words) and small generic cleanup
…so updates the coalesced writing to sysmem to work with large reduce_t types, such that sizeof(device_reduce_t) / sizeof(atomic_type<device_reduce_t>) > warp_size, which previously was a restriction: we now use a warp-stride loop to do a coalesced write to sysmem
…MP at present and just a simple gather method for now
…to real_t done after the multi-process reduction
…r direct comparisons, use max error not error sum when multiple norms are used to check correctness, print out the deviation when verbosity >= QUDA_VERBOSE
…itations representing this being WIP (bin bounds LUT repeatadly recomputed on the host, bin bounds LUT presently in explicit constant, CG reduction not supported, warp reductions rather register heavy, etc.)
…to feature/reproducible
… variables (remove bad cast)
…lizing the reduction. All tests passing, but seemingly break when a SANITIZE build is used
…to feature/reproducible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this isn't ready to be merged, I'm creating this PR as a placeholder.)