Added a test to ensure our bits are Java8 compatible #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renovate wants to bump up dependencies all the time, so it's important now that we can flag dependencies that are too new. I originally had animal-sniffer as another test only artifact, but Bazel still complained that plexus depends on junit yet plexus is not marked test only. My guess is that the test only bit doesn't flow through transitive dependencies. I suppose I could have explicitly marked every intermediate dependencies, but that didn't seem to be worth the effort, so I chickened out to an easier path, which is just to remove the test only flag from junit. It makes this file shorter, which is a plus, too. The default visibility in the src package was needed in order to make deploy_jar visible to the test package. I would have expected the existing public visibility in the java_library would have been sufficient, but evidently it wasn't. This is a small project, so the downside of the loose visibility is limited.
|
Merged
Konboi
approved these changes
Jan 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renovate wants to bump up dependencies all the time, so it's important now that we can flag dependencies that are too new.
I originally had animal-sniffer as another test only artifact, but Bazel still complained that plexus depends on junit yet plexus is not marked test only. My guess is that the test only bit doesn't flow through transitive dependencies.
I suppose I could have explicitly marked every intermediate dependencies, but that didn't seem to be worth the effort, so I chickened out to an easier path, which is just to remove the test only flag from junit. It makes this file shorter, which is a plus, too.
The default visibility in the src package was needed in order to make deploy_jar visible to the test package. I would have expected the existing public visibility in the java_library would have been sufficient, but evidently it wasn't. This is a small project, so the downside of the loose visibility is limited.