Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

<ItemGroup>
<PackageReference Include="LaunchDarkly.ServerSdk" Version="[8.1.0,9.0)" />
<PackageReference Include="OpenFeature" Version="[2.0.0, 3.0.0)" />
<PackageReference Include="OpenFeature" Version="[2.2.0, 3.0.0)" />
</ItemGroup>

<PropertyGroup>
Expand Down
21 changes: 20 additions & 1 deletion src/LaunchDarkly.OpenFeature.ServerProvider/Provider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ await EventChannel.Writer.WriteAsync(new ProviderEventPayload
{
ProviderName = _metadata.Name,
Type = ProviderEventTypes.ProviderConfigurationChanged,
FlagsChanged = new List<string> {changeEvent.Key},
FlagsChanged = new List<string> { changeEvent.Key },
}).ConfigureAwait(false);
}
catch (Exception e)
Expand Down Expand Up @@ -217,5 +217,24 @@ private void StatusChangeHandler(object sender, DataSourceStatus status)
break;
}
}

/// <inheritdoc />
public override void Track(string trackingEventName, EvaluationContext evaluationContext = null, TrackingEventDetails trackingEventDetails = default)
{
var (value, details) = trackingEventDetails.ToLdValue();

if (value.HasValue)
{
_client.Track(trackingEventName, _contextConverter.ToLdContext(evaluationContext), details, value.Value);
}
else if (details.Type != LdValueType.Null)
{
_client.Track(trackingEventName, _contextConverter.ToLdContext(evaluationContext), details);
}
else
{
_client.Track(trackingEventName, _contextConverter.ToLdContext(evaluationContext));
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
using LaunchDarkly.Sdk;
using OpenFeature.Model;

namespace LaunchDarkly.OpenFeature.ServerProvider
{
internal static class TrackingEventDetailsExtensions
{
/// <summary>
/// Extract an OpenFeature <see cref="TrackingEventDetails"/> into an <see cref="LdValue"/>.
/// </summary>
/// <param name="trackingEventDetails">The value to extract</param>
public static (double?, LdValue) ToLdValue(this TrackingEventDetails trackingEventDetails)
{
if (trackingEventDetails == null)
{
return (null, LdValue.Null);
}

var value = trackingEventDetails.Value;

LdValue details;
if (trackingEventDetails.Count == 0)
{
details = LdValue.Null;
}
else
{
var builder = LdValue.BuildObject();
foreach (var keyvalue in trackingEventDetails)
{
builder.Add(keyvalue.Key, keyvalue.Value.ToLdValue());
}
details = builder.Build();
}

return (value, details);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<PackageReference Include="LaunchDarkly.ServerSdk" Version="8.5.1" />
<PackageReference Include="LaunchDarkly.TestHelpers" Version="2.0.0" />
<PackageReference Include="Moq" Version="4.8.1" />
<PackageReference Include="OpenFeature" Version="2.0.0" />
<PackageReference Include="OpenFeature" Version="2.2.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -272,5 +272,73 @@ public async Task ItEmitsConfigurationChangedEvents()
Assert.Single(eventPayloadB?.FlagsChanged ?? new List<string>());
Assert.NotEqual(eventPayloadA?.FlagsChanged[0], eventPayloadB?.FlagsChanged[0]);
}

[Fact(Timeout = 5000)]
public void ItTracksCustomEvents()
{
var evaluationContext = EvaluationContext.Builder()
.Set("targetingKey", "the-key")
.Build();
var mock = new Mock<ILdClient>();
mock.Setup(l => l.GetLogger())
.Returns(Components.NoLogging.Build(null).LogAdapter.Logger(null));
mock.Setup(l => l.Track("event-key-123abc", _converter.ToLdContext(evaluationContext))).Verifiable();
var provider = new Provider(mock.Object);

provider.Track("event-key-123abc", evaluationContext);

mock.Verify();
}

[Fact(Timeout = 5000)]
public void ItTracksCustomEventsWithValue()
{
var evaluationContext = EvaluationContext.Builder()
.Set("targetingKey", "the-key")
.Build();
var mock = new Mock<ILdClient>();
mock.Setup(l => l.GetLogger())
.Returns(Components.NoLogging.Build(null).LogAdapter.Logger(null));
mock.Setup(l => l.Track("event-key-123abc", _converter.ToLdContext(evaluationContext), LdValue.Null, 99.77)).Verifiable();
var provider = new Provider(mock.Object);

provider.Track("event-key-123abc", evaluationContext, TrackingEventDetails.Builder().SetValue(99.77).Build());

mock.Verify();
}

[Fact(Timeout = 5000)]
public void ItTracksCustomEventsWithDetails()
{
var evaluationContext = EvaluationContext.Builder()
.Set("targetingKey", "the-key")
.Build();
var mock = new Mock<ILdClient>();
mock.Setup(l => l.GetLogger())
.Returns(Components.NoLogging.Build(null).LogAdapter.Logger(null));
mock.Setup(l => l.Track("event-key-123abc", _converter.ToLdContext(evaluationContext), LdValue.BuildObject().Set("color", "red").Build())).Verifiable();
var provider = new Provider(mock.Object);

provider.Track("event-key-123abc", evaluationContext, TrackingEventDetails.Builder().Set("color", "red").Build());

mock.Verify();
}

[Fact(Timeout = 5000)]
public void ItTracksCustomEventsWithDetailsAndValue()
{
var evaluationContext = EvaluationContext.Builder()
.Set("targetingKey", "the-key")
.Build();
var mock = new Mock<ILdClient>();
mock.Setup(l => l.GetLogger())
.Returns(Components.NoLogging.Build(null).LogAdapter.Logger(null));
mock.Setup(l => l.Track("event-key-123abc", _converter.ToLdContext(evaluationContext), LdValue.BuildObject().Set("currency", "USD").Build(), 99.77)).Verifiable();
var provider = new Provider(mock.Object);

provider.Track("event-key-123abc", evaluationContext, TrackingEventDetails.Builder().SetValue(99.77).Set("currency", "USD").Build());

mock.Verify();
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
using LaunchDarkly.Sdk;
using OpenFeature.Model;
using Xunit;

namespace LaunchDarkly.OpenFeature.ServerProvider.Tests
{
public class TrackingEventDetailsExtensionsTest
{
[Fact]
public void ItCanHandleValuesAndDetails()
{
var trackingEventDetails = TrackingEventDetails.Builder().SetValue(99.77).Set("currency", "USD").Build();
var (value, details) = trackingEventDetails.ToLdValue();
Assert.Equal(LdValueType.Object, details.Type);
Assert.Equal(LdValue.Of("USD"), details.Get("currency"));
Assert.Equal(99.77, value);
}

[Fact]
public void ItCanHandleDetailsOnly()
{
var trackingEventDetails = TrackingEventDetails.Builder().Set("color", "red").Build();
var (value, details) = trackingEventDetails.ToLdValue();
Assert.Equal(LdValueType.Object, details.Type);
Assert.Equal(LdValue.Of("red"), details.Get("color"));
Assert.Null(value);
}

[Fact]
public void ItCanHandleValuesOnly()
{
var trackingEventDetails = TrackingEventDetails.Builder().SetValue(99.77).Build();
var (value, details) = trackingEventDetails.ToLdValue();
Assert.Equal(LdValueType.Null, details.Type);
Assert.Equal(99.77, value);
}

[Fact]
public void ItCanHandleEmptyStructures()
{
var trackingEventDetails = TrackingEventDetails.Empty;
var (value, details) = trackingEventDetails.ToLdValue();
Assert.Equal(LdValueType.Null, details.Type);
Assert.Null(value);
}

[Fact]
public void ItCanHandleNull()
{
TrackingEventDetails trackingEventDetails = null;
var (value, details) = trackingEventDetails.ToLdValue();
Assert.Equal(LdValueType.Null, details.Type);
Assert.Null(value);
}
}
}