Fix: Improve typing support #202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All callable arguments have been updated to match how they are used in code Some checks have been extracted to a PEP 742 TypeIs function. A side-effect of this is typing-extensions>4.10 requires python 3.8. The only functional change is in moving LimitGroup.request to a function argument, which makes LimitGroup stateless and less prone to a race condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All callable arguments have been updated to match how they are used in code.
Some checks have been extracted to a PEP 742
TypeIsfunction. A side-effect of this is typing-extensions>4.10 requires python 3.8.The only functional changes is in moving
LimitGroup.requestto a function argument, which makesLimitGroupstateless and less prone to a race condition.Limit.scopewas also changed from a property to a normal method sorequestcan be passed. Additionally,Limiter.slowapi_startup()has received a parameterapp: Starlette. Without it, aNameError: appwould be raised when called.