-
Notifications
You must be signed in to change notification settings - Fork 36
Added Meshery design for architecture section #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Meshery design for architecture section #322
Conversation
Signed-off-by: AasthathecoderX <[email protected]>
@AasthathecoderX can you remove.png |
Signed-off-by: AasthathecoderX <[email protected]>
@saurabhraghuvanshii ,I haven't added any .png |
@AasthathecoderX no no you take me wrong. You should keep .js .yaml as it. There is .png already when you embed new design remove old .png with new design. |
@AasthathecoderX put .js .yaml correctly . And run repo using make site to check your Embedding if it working or not |
@saurabhraghuvanshii ,oh ok,I got what you mean now.I will do it. |
Signed-off-by: AasthathecoderX <[email protected]>
@AasthathecoderX add .js .yaml back to repo the. It will work |
Signed-off-by: AasthathecoderX <[email protected]>
@saurabhraghuvanshii ,done |
@AasthathecoderX now run academy on localhost using |
Signed-off-by: AasthathecoderX <[email protected]>
@saurabhraghuvanshii ,here is the screen shot: |
@AasthathecoderX you embed design wrong place put it on shared path also move yaml js in switch routing folder. Are you even paying attention? |
@saurabhraghuvanshii ,my bad,I think while following the direction as in the previous PR's ,I forgot to replace the embedding in proper folder.Sorry for the inconvenience. |
Also the above diagram is in 2 places one in networking folder and another in switching ,I should replace in both right? |
Yes if both are same and also put js yaml at both place |
Signed-off-by: AasthathecoderX <[email protected]>
Signed-off-by: AasthathecoderX <[email protected]>
@saurabhraghuvanshii ,done |
...37c-47ea-ab43-5716e3bcab2e/exoscale-101/advanced-course/networks/switching-routing/_index.md
Outdated
Show resolved
Hide resolved
...e46-937c-47ea-ab43-5716e3bcab2e/exoscale-101/advanced-course/advanced/architecture/_index.md
Show resolved
Hide resolved
Signed-off-by: AasthathecoderX <[email protected]>
@AasthathecoderX thanks lgtm |
Notes for Reviewers
This PR fixes #157
Signed commits