Skip to content

Conversation

AasthathecoderX
Copy link
Contributor

Notes for Reviewers

This PR fixes #157

Signed commits

  • Yes, I signed my commits.

@saurabhraghuvanshii
Copy link
Contributor

saurabhraghuvanshii commented Oct 15, 2025

@AasthathecoderX can you remove.png
Of design and share Share screenshot how's it looks

@AasthathecoderX
Copy link
Contributor Author

@saurabhraghuvanshii ,I haven't added any .png
for the review below is the image:
image

@saurabhraghuvanshii
Copy link
Contributor

@AasthathecoderX no no you take me wrong. You should keep .js .yaml as it. There is .png already when you embed new design remove old .png with new design.

@saurabhraghuvanshii
Copy link
Contributor

saurabhraghuvanshii commented Oct 15, 2025

@AasthathecoderX put .js .yaml correctly . And run repo using make site to check your Embedding if it working or not

@AasthathecoderX
Copy link
Contributor Author

@AasthathecoderX put .js .yaml correctly . And run repo using make site to check your Embedding if it working or not

@saurabhraghuvanshii ,oh ok,I got what you mean now.I will do it.

@saurabhraghuvanshii
Copy link
Contributor

@AasthathecoderX add .js .yaml back to repo the. It will work

@AasthathecoderX
Copy link
Contributor Author

@saurabhraghuvanshii ,done

@saurabhraghuvanshii
Copy link
Contributor

saurabhraghuvanshii commented Oct 15, 2025

@AasthathecoderX now run academy on localhost using make site and see your changes please and share screenshot. In short verify it

@AasthathecoderX
Copy link
Contributor Author

@saurabhraghuvanshii ,here is the screen shot:
image

@saurabhraghuvanshii
Copy link
Contributor

@AasthathecoderX you embed design wrong place put it on shared path also move yaml js in switch routing folder. Are you even paying attention?

@AasthathecoderX
Copy link
Contributor Author

@saurabhraghuvanshii ,my bad,I think while following the direction as in the previous PR's ,I forgot to replace the embedding in proper folder.Sorry for the inconvenience.

@AasthathecoderX
Copy link
Contributor Author

Also the above diagram is in 2 places one in networking folder and another in switching ,I should replace in both right?

@saurabhraghuvanshii
Copy link
Contributor

saurabhraghuvanshii commented Oct 15, 2025

Also the above diagram is in 2 places one in networking folder and another in switching ,I should replace in both right?

Yes if both are same and also put js yaml at both place

Signed-off-by: AasthathecoderX <[email protected]>
Signed-off-by: AasthathecoderX <[email protected]>
@AasthathecoderX
Copy link
Contributor Author

@saurabhraghuvanshii ,done

Signed-off-by: AasthathecoderX <[email protected]>
@saurabhraghuvanshii
Copy link
Contributor

@AasthathecoderX thanks lgtm

@saurabhraghuvanshii saurabhraghuvanshii added the hacktoberfest-accepted Happy contributing! label Oct 15, 2025
@saurabhraghuvanshii saurabhraghuvanshii merged commit 0d9f667 into layer5io:master Oct 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Advanced Course Image-3

2 participants