Skip to content

Conversation

shivangshandilya
Copy link

Description

This PR fixes #288

Notes for Reviewers

log.Fatal() has been replaced with log.Error()

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shivang Shandilya <[email protected]>
@welcome
Copy link

welcome bot commented Apr 11, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@leecalcote leecalcote requested a review from gyohuangxin April 11, 2023 16:27
@leecalcote leecalcote added the language/go Golang related label Apr 11, 2023
Copy link

@gyohuangxin gyohuangxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivangshandilya Thanks for your PR, I left a comment.

@gyohuangxin gyohuangxin requested a review from leecalcote April 15, 2023 13:23
@leecalcote leecalcote requested review from Revolyssup and removed request for leecalcote May 2, 2023 15:41
@Chadha93
Copy link
Member

Thanks, @shivangshandilya, could you help with the Go lint issue too here?

@shivangshandilya
Copy link
Author

Thanks, @shivangshandilya, could you help with the Go lint issue too here?

Can you elaborate on this??

@Sweetdevil144
Copy link

I personally would favor usage of log.Fatal instead of consequent log.Error and return statements. It is because return statementstend to return while log.Fatal tends to stop the program. Imagine threading situations, where Fatal would be preferred over return's. I'd say this PR will rather degrade the system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

language/go Golang related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes in main.go

5 participants