Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add naming convention for Prop-valued classes #592

Open
wants to merge 1 commit into
base: lean4
Choose a base branch
from
Open

feat: add naming convention for Prop-valued classes #592

wants to merge 1 commit into from

Conversation

kbuzzard
Copy link
Member

@kbuzzard kbuzzard commented Feb 16, 2025 •
edited
Loading

This is a proposal for a naming convention for Prop-valued classes. The proposal is that nouns get Is and adjectives do not.

@kbuzzard
Copy link
Member Author

kbuzzard commented Feb 16, 2025 •
edited
Loading

I personally would prefer that every Prop-valued class gets an Is for consistency but this proposal has never seemed to be a popular one. However TopologicalRing has always been a terrible name for a Prop, in my opinion, regardless of anyone's thoughts on a general convention, and my PR to add Is is here leanprover-community/mathlib4#21472 .

@kbuzzard kbuzzard mentioned this pull request Feb 16, 2025
Closed
@fpvandoorn
Copy link
Member

LGTM. Is there a consensus on Zulip that this is what we want?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbuzzard @fpvandoorn