-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: review the simps
projections of OneHom
, MulHom
, MonoidHom
#19860
base: master
Are you sure you want to change the base?
Conversation
PR summary db132ee79dImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
simps
projections of OneHom
, Mulhom
, MonoidHom
simps
projections of OneHom
, MulHom
, MonoidHom
Yes, the state of You can do what you want in a verbose way: -- the `-apply` means that `simps` doesn't generate this lemma by default
initialize_simps_projections OneHom (toFun → coe, as_prefix coe, toFun → apply, -apply)
-- the second `simps` call generates the `apply` lemma anyway
@[simps -fullyApplied, simps apply]
def something : OneHom _ _ Once #19895 is implemented you could enable both by default (this will generate |
15f12bb
to
a4334e6
Compare
a4334e6
to
a8e1e42
Compare
…idHom` Make `simps` generate `coe_concreteHom` rather than`concreteHom_apply`. From FLT
a8e1e42
to
db132ee
Compare
Make
simps
generatecoe_concreteHom
rather thanconcreteHom_apply
.From FLT
In fact, I would love to have both the
coe_
and_apply
projections simultaneously and also to not have to specifysimps (config := .asFn))
every single time we want to generate thecoe_
projection, butsimps
seems to not be able to do that? cc @fpvandoornI must say, after four years of working on mathlib, I still don't understand how one is supposed to use
simps
.