-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: shortlex order on lists #20310
base: master
Are you sure you want to change the base?
Conversation
messageFile.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments, sorry for not having time right now for a more thorough review.
Co-authored-by: Eric Wieser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming largely looks good now, thanks! (or at least, as good as the existing List.Lex
naming...)
Perhaps @vihdzp has some opinions around the names of the WellFounded stuff, and whether some instance
s are missing.
Co-authored-by: Eric Wieser <[email protected]>
Co-authored-by: Eric Wieser <[email protected]>
I noticed that there is something going on with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial remarks. I expect that there's a lot of golfing that can be done here.
Co-authored-by: Violeta Hernández <[email protected]>
Co-authored-by: Violeta Hernández <[email protected]>
Co-authored-by: Violeta Hernández <[email protected]>
messageFile.md |
Co-authored-by: Violeta Hernández <[email protected]>
messageFile.md |
1 similar comment
messageFile.md |
messageFile.md |
messageFile.md |
messageFile.md |
messageFile.md |
If you merge master, then the bot will stop posting such silly messages! |
PR summary ec90975413Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
We certainly want to have |
Co-authored-by: Violeta Hernández <[email protected]>
Given a relation
r
on a typeα
, the shortlex order overr
on lists (first compare by length; if equal, then compare by lexicographic order overr
) is defined. We prove that this inherits properties from the underlying relationr
such as trichotomous-icity, asymmetry, order-connectedness.Most importantly,
Shortlex r
is well-founded ifr
is well-founded, giving a well-founded order on lists. (Notably, List.Lex is not well-founded).