Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(SetTheory/Game/PGame): EquivAntisymmRel #21086

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jan 26, 2025

We replace PGame.Equiv by the more general AntisymmRel. This is part of #19588.

We've kept both the setoid notation , as well as equiv within theorem names. We've deprecated any results that are more generally true on preorders, save for those on LF which will be dealt with separately.


Although we can now define Game = Antisymmetrization PGame (· ≤ ·), doing so means that ⟦x⟧ notation breaks. Given that we can still use instPartialOrderAntisymmetrization to declare the partial order instance, it might not even be worth to do this redefinition. In any case, that probably should be discussed separately.

Open in Gitpod

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Jan 26, 2025
Copy link

github-actions bot commented Jan 26, 2025

PR summary 9a4093deaa

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.SetTheory.Game.PGame 483 484 +1 (+0.21%)
Mathlib.SetTheory.Game.Basic 534 535 +1 (+0.19%)
Mathlib.SetTheory.Game.Impartial 535 536 +1 (+0.19%)
Import changes for all files
Files Import difference
3 files Mathlib.SetTheory.Game.Basic Mathlib.SetTheory.Game.Impartial Mathlib.SetTheory.Game.PGame
1

Declarations diff

+ equiv_of_equiv
+ equiv_of_exists
+ instance : @Trans PGame PGame PGame (· < ·) (· ≈ ·) (· < ·)
+ instance : @Trans PGame PGame PGame (· ≈ ·) (· < ·) (· < ·)
+ instance : @Trans PGame PGame PGame (· ≈ ·) (· ≤ ·) (· ≤ ·)
+ instance : @Trans PGame PGame PGame (· ≤ ·) (· ≈ ·) (· ≤ ·)
- instance : IsEquiv _ PGame.Equiv
---- instance : Trans

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (2.00, 0.00)
Current number Change Type
3841 -2 porting notes

Current commit 9a4093deaa
Reference commit b77fbf3757

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@vihdzp vihdzp requested a review from LeoDog896 January 26, 2025 12:27
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) labels Jan 26, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 26, 2025
@github-actions github-actions bot removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) large-import Automatically added label for PRs with a significant increase in transitive imports labels Jan 27, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jan 27, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 27, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 28, 2025
Copy link
Collaborator

@LeoDog896 LeoDog896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I conceptually have no problem with this: redefining Equiv in this way is better towards the goal of better Game generalizations. I don't have any extra comments because I can't spot anything wrong with any of the formalization refactors, but I'm not experienced in that regard.

mathlib-bors bot pushed a commit that referenced this pull request Feb 4, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Feb 4, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 4, 2025
pfaffelh pushed a commit that referenced this pull request Feb 7, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 11, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-CI merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-combinatorics Combinatorics t-set-theory Set theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants