Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SetTheory/Game/Impartial): Better iff lemmas #21110

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jan 27, 2025

This PR does the following:

  • make x ≈ 0 and x ‖ 0 the simp-normal forms of x ≤ 0, x ⧏ 0, etc. on impartial games.
  • swap the direction of some iff lemmas whose LHS were too specific to ever realistically appear.
  • make the game argument implicit in all of these lemmas.
  • drive-by golfing.

Open in Gitpod

Copy link

github-actions bot commented Jan 27, 2025

PR summary 4d0746a884

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ equiv_zero_iff_forall_leftMoves_fuzzy
+ equiv_zero_iff_forall_rightMoves_fuzzy
+ fuzzy_zero_iff_exists_leftMoves_equiv
+ fuzzy_zero_iff_exists_rightMoves_equiv
+ le_zero_iff_equiv
+ lf_zero_iff_fuzzy
+ zero_le_iff_equiv
+ zero_lf_iff_fuzzy

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-set-theory Set theory label Jan 27, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jan 27, 2025
rw [← zero_lf_neg_iff, lf_congr_right (neg_equiv_self G)]

@[simp]
theorem le_zero_iff_equiv : G ≤ 0 ↔ G ≈ 0 :=
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might have an overly strong discrimination key, should I make it scoped simp?

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 17, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Feb 18, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-set-theory Set theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants