Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NumberField/MixedSpace): add polar coordinates change of variables (part 2) #22115

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Feb 20, 2025

@xroblot xroblot added the WIP Work in progress label Feb 20, 2025
Copy link

github-actions bot commented Feb 20, 2025

PR summary cde33100b6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.NumberTheory.NumberField.CanonicalEmbedding.PolarCoord (new file) 2562

Declarations diff

+ FDerivPolarCoordRealSymm
+ continuous_polarCoord_symm
+ det_fderivPolarCoordRealSymm
+ det_prodMap
+ hasFDerivAt_polarCoordReal_symm
+ homeoRealMixedSpacePolarSpace
+ homeoRealMixedSpacePolarSpace_apply
+ homeoRealMixedSpacePolarSpace_apply_fst_ofIsComplex
+ homeoRealMixedSpacePolarSpace_apply_fst_ofIsReal
+ homeoRealMixedSpacePolarSpace_apply_snd
+ homeoRealMixedSpacePolarSpace_symm_apply
+ injective_mixedSpaceOfRealSpace
+ instance : IsAddHaarMeasure (volume : Measure (realMixedSpace K)) := prod.instIsAddHaarMeasure _ _
+ integral_comp_polarCoordReal_symm
+ integral_comp_polarCoord_symm
+ integral_comp_polarSpaceCoord_symm
+ lintegral_comp_polarCoordReal_symm
+ lintegral_comp_polarCoord_symm
+ lintegral_comp_polarSpaceCoord_symm
+ measurableEquivRealMixedSpacePolarSpace
+ measurable_polarCoordReal_symm
+ measurable_polarCoord_symm
+ measurable_polarSpaceCoord_symm
+ mem_iff_normAtAllPlaces_mem
+ mem_iff_normAtAllPlaces_mem_iff
+ mixedSpaceNormAtAllPlaces_apply
+ mixedSpaceOfRealSpace
+ mixedSpaceOfRealSpace_apply
+ mixedSpaceToRealMixedSpace
+ mixedSpaceToRealMixedSpace_apply
+ negAt_apply_norm_of_isReal
+ normAtAllPlaces
+ normAtAllPlaces_apply
+ normAtAllPlaces_normAtAllPlaces
+ normAtComplexPlaces
+ normAtComplexPlaces_apply_ofIsComplex
+ normAtComplexPlaces_apply_ofIsReal
+ normAtComplexPlaces_eq_normAtComplexPlaces_iff
+ normAtComplexPlaces_mixedSpaceOfReal
+ normAtComplexPlaces_preimage_image_eq
+ normAtPlace_apply_of_isComplex
+ normAtPlace_apply_of_isReal
+ normAtPlace_polarCoord_symm_of_isComplex
+ normAtPlace_polarCoord_symm_of_isReal
+ normMapComplex_polarSpaceCoord
+ polarCoord
+ polarCoordReal
+ polarCoordReal_source
+ polarCoordReal_symm_target_ae_eq_univ
+ polarCoord_symm_eq
+ polarCoord_target_eq_polarCoordReal_target
+ polarSpace
+ polarSpaceCoord
+ polarSpaceCoord_target'
+ realMixedSpace
+ realSpace
+ realSpace.volume_eq_zero
+ realSpaceNormAtComplexPlaces
+ realSpaceNormAtComplexPlaces_apply_ofIsComplex
+ realSpaceNormAtComplexPlaces_apply_ofIsReal
+ volume_eq_two_pi_pow_mul_integral
+ volume_eq_two_pow_mul_two_pi_pow_mul_integral
+ volume_eq_two_pow_mul_two_pi_pow_mul_integral_aux₁
+ volume_preserving_homeoRealMixedSpacePolarSpace
+ volume_preserving_mixedSpaceToRealMixedSpace_symm
- normAtPlace_apply_isComplex
- normAtPlace_apply_isReal

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
1309 1 erw

Current commit cde33100b6
Reference commit ab742a3f6b

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@xroblot xroblot changed the title feat(NumberField/MixedSpace): add polar coordinates change of variables feat(NumberField/MixedSpace): add polar coordinates change of variables (part 2) Feb 20, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Feb 20, 2025
@mathlib4-dependent-issues-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants