Skip to content

[Merged by Bors] - chore(CategoryTheory/Galois): fix namespace for getFiberFunctor - #42610

Closed
joelriou wants to merge 2 commits into
leanprover-community:masterfrom
joelriou:fix-galois-category-fiber-functor
Closed

[Merged by Bors] - chore(CategoryTheory/Galois): fix namespace for getFiberFunctor#42610
joelriou wants to merge 2 commits into
leanprover-community:masterfrom
joelriou:fix-galois-category-fiber-functor

Conversation

@joelriou

Copy link
Copy Markdown
Contributor

PreGaloisCategory.GaloisCategory.getFiberFunctor is renamed GaloisCategory.getFiberFunctor.


Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Aug 10, 2026
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

PR summary f2e14c9e23

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ PreGaloisCategory.GaloisCategory.getFiberFunctor
+ instance : FiberFunctor (getFiberFunctor C)
- instance : FiberFunctor (GaloisCategory.getFiberFunctor C)

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit f2e14c9).

  • +1 new declarations
  • −0 removed declarations
+CategoryTheory.GaloisCategory.getFiberFunctor

No changes to strong technical debt.

No changes to weak technical debt.

Current commit f2e14c9e23
Reference commit 3b5417e200

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@dagurtomas dagurtomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this may conflict with the other PR on Galois categories that I maintainer merged, just take care when merging.

maintainer merge?

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by dagurtomas.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 12, 2026

@jcommelin jcommelin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Aug 12, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 12, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Aug 12, 2026
…2610)

`PreGaloisCategory.GaloisCategory.getFiberFunctor` is renamed `GaloisCategory.getFiberFunctor`.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Aug 12, 2026
@mathlib-bors

mathlib-bors Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title chore(CategoryTheory/Galois): fix namespace for getFiberFunctor [Merged by Bors] - chore(CategoryTheory/Galois): fix namespace for getFiberFunctor Aug 12, 2026
@mathlib-bors mathlib-bors Bot closed this Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants