Skip to content

[Merged by Bors] - feat(RingTheory/Nilpotents): basic MulOpposite lemmas for IsNilpotent/IsReduced - #42625

Closed
vlad902 wants to merge 5 commits into
leanprover-community:masterfrom
vlad902:nilpotent-reduced-mulopposite
Closed

[Merged by Bors] - feat(RingTheory/Nilpotents): basic MulOpposite lemmas for IsNilpotent/IsReduced#42625
vlad902 wants to merge 5 commits into
leanprover-community:masterfrom
vlad902:nilpotent-reduced-mulopposite

Conversation

@vlad902

@vlad902 vlad902 commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Open in Gitpod

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

PR summary beeca9c3f8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ IsNilpotent.op
+ IsNilpotent.unop
+ instance [MonoidWithZero R] [IsReduced R] : IsReduced Rᵐᵒᵖ
+ isNilpotent_op
+ isNilpotent_unop
+ isReduced_mulOpposite_iff

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit beeca9c).

  • +6 new declarations
  • −0 removed declarations
+IsNilpotent.op
+IsNilpotent.unop
+instIsReducedMulOpposite
+isNilpotent_op
+isNilpotent_unop
+isReduced_mulOpposite_iff

No changes to strong technical debt.

No changes to weak technical debt.

Current commit beeca9c3f8
Reference commit 2918a25dd5

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-ring-theory Ring theory label Aug 10, 2026
Comment thread Mathlib/RingTheory/Nilpotent/Defs.lean Outdated
Comment thread Mathlib/RingTheory/Nilpotent/Defs.lean Outdated

@eric-wieser eric-wieser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer delegate

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by eric-wieser.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 11, 2026
vlad902 and others added 3 commits August 11, 2026 08:10
@ocfnash

ocfnash commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Aug 11, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 11, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Aug 11, 2026
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Aug 11, 2026
@mathlib-bors

mathlib-bors Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title feat(RingTheory/Nilpotents): basic MulOpposite lemmas for IsNilpotent/IsReduced [Merged by Bors] - feat(RingTheory/Nilpotents): basic MulOpposite lemmas for IsNilpotent/IsReduced Aug 11, 2026
@mathlib-bors mathlib-bors Bot closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants