feat: replace use of (evalTactic bv_omega) with a manual run of simp followed by (evalTactic omega) #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… directly invoke `omega`
alexkeizer
reviewed
Sep 27, 2024
|
@alexkeizer I addressed one of your comments, and I ignored two of them, because it's not clear to me that it's the right design. I prefer YAGNI, so I'm happy with the patch as-is. What do you feel? |
shigoel
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We're attempting to make
simp_memfaster by controlling the evaluation of bothsimpandomega. Toward this, as a first step, we invokesimpourselves.Testing:
What tests have been run? Did
make allsucceed for your changes? Wasconformance testing successful on an Aarch64 machine?
Conformance succeeds.
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.