Scope docker hub login to push, and add attestations#14524
Open
bjester wants to merge 1 commit intolearningequality:developfrom
Open
Scope docker hub login to push, and add attestations#14524bjester wants to merge 1 commit intolearningequality:developfrom
bjester wants to merge 1 commit intolearningequality:developfrom
Conversation
github-actions
bot
added
DEV: dev-ops
bjester
force-pushed
the
fix-container-publish
branch
from
880de0e to
d18da55
Compare
Contributor
Build Artifacts
Smoke test screenshot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new container publishing workflow worked for Github but failed for Docker Hub:
Looking at the documentation for the
login-action, it mentions default token overriding. I don't think this will fix the issue, since it describes login tokens overriding Github's, but worth a shot.Also adds attestations according to Github's docs
References
https://github.com/learningequality/kolibri/actions/runs/23910966630