Skip to content

Update course title#14557

Open
AlexVelezLl wants to merge 2 commits intolearningequality:release-v0.19.xfrom
AlexVelezLl:update-course-title
Open

Update course title#14557
AlexVelezLl wants to merge 2 commits intolearningequality:release-v0.19.xfrom
AlexVelezLl:update-course-title

Conversation

@AlexVelezLl
Copy link
Copy Markdown
Member

Summary

  • The side panel in ResourceLayout now opens by default when the screen is large enough (non-modal breakpoint), using a watcher that triggers immediately on mount.
  • The page title in CourseUnitView is now shows the pre/post-test title (e.g. "Unit 2: Algebra - Pre-test") during tests, the current resource title when viewing a resource, and falls back to the course name.
  • Course title is now wrapped in a <h1> tag.

References

Closes #14522.

Reviewer guidance

Check #14522.

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: small labels Apr 8, 2026
@AlexVelezLl AlexVelezLl force-pushed the update-course-title branch from 828c1e7 to c1309d2 Compare April 8, 2026 19:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

/>
<h1>
<KTextTruncator
:maxLines="1"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks exactly like the expected code, but when I was reviewing in the browser, it looks like the title isn't actually truncating with the '...' the way I would expect. This might be something in the KTextTruncator? I'm not totally sure. It's also possible that it's just because it's local and i'm resizing the page, but it looks like it's covering the hamburger icon as well.

Screen.Recording.2026-04-09.at.9.09.40.AM.mov

Is this something you can reproduce as well Alex, or is it just me?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I thought I had already fixed that in the past, in general this is a problem with our KToolbar, we could set this min-width on KDS, but that'd take time to see that this introduces no regressions, and since we will have a refactor on KToolbar anyways learningequality/kolibri-design-system#1183, I think its okay just to add this with the deep selector.

Here is the fix.

Grabacion.de.pantalla.2026-04-09.a.la.s.9.40.01.a.m.mov

isSidePanelModalMode,
newIsModal => {
if (!newIsModal) {
// Have side panel open by default on larger screens
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this -- I think we may have lost this behavior somewhere along the way but I'm not sure where and it wasn't intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants