Update course title#14557
Update course title#14557AlexVelezLl wants to merge 2 commits intolearningequality:release-v0.19.xfrom
Conversation
828c1e7 to
c1309d2
Compare
Build Artifacts
Smoke test screenshot |
| /> | ||
| <h1> | ||
| <KTextTruncator | ||
| :maxLines="1" |
There was a problem hiding this comment.
This looks exactly like the expected code, but when I was reviewing in the browser, it looks like the title isn't actually truncating with the '...' the way I would expect. This might be something in the KTextTruncator? I'm not totally sure. It's also possible that it's just because it's local and i'm resizing the page, but it looks like it's covering the hamburger icon as well.
Screen.Recording.2026-04-09.at.9.09.40.AM.mov
Is this something you can reproduce as well Alex, or is it just me?
There was a problem hiding this comment.
Hmmm, I thought I had already fixed that in the past, in general this is a problem with our KToolbar, we could set this min-width on KDS, but that'd take time to see that this introduces no regressions, and since we will have a refactor on KToolbar anyways learningequality/kolibri-design-system#1183, I think its okay just to add this with the deep selector.
Here is the fix.
Grabacion.de.pantalla.2026-04-09.a.la.s.9.40.01.a.m.mov
| isSidePanelModalMode, | ||
| newIsModal => { | ||
| if (!newIsModal) { | ||
| // Have side panel open by default on larger screens |
There was a problem hiding this comment.
Thank you for fixing this -- I think we may have lost this behavior somewhere along the way but I'm not sure where and it wasn't intentional.
c1309d2 to
ec320bf
Compare
Summary
<h1>tag.References
Closes #14522.
Reviewer guidance
Check #14522.