Fix error handling #377
Closed
Fix error handling #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are promises, we need to use `await` to be able to catch the errors. For example in https://github.com/mui/mui-x/actions/runs/3350385087/jobs/5551157153 we don't set the right permissions. We use "Default access (restricted)" https://docs.github.com/en/actions/security-guides/automatic-token-authentication
|
No review, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are promises, we need to use
awaitto be able to catch the errors. For example, in https://github.com/mui/mui-x/actions/runs/3350385087/jobs/5551157153 the job failed but is marked as successful 🙈.(The job failed because MUI didn't set the right permissions, we use "Default access restricted" in https://docs.github.com/en/actions/security-guides/automatic-token-authentication).
Context: mui/mui-x#6658