ROS 2 Humble Python and C++ Support #110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing cupy/numpy bool8 type issue, updating package.xmls Adjusting quality of service a bit Enabling other layers e.g. rgb in pointcloud2 subscriber
Mostly fixing rosdep names
Still need to test cpp version
fix import of param file
fixing published map topic namespacing Got rid of some unused parameters
…make_python. Currently requires comment in and out parts of package.xml Idea is that if you don't want the cpp package you could just use the python one without building using cmake
Still debugging issue with ament_python_install_package()
Builds now
…aner Fixed bug in numpy array conversion
|
Thanks for the pull request! i'll test your cpp bindings and then merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the changes on the ros2_py branch with the @amilearning's ros2_humble_orin branch so that both the python ros2 node and the C++ node function. I had to do some reorganizing of @amilearning's commits to reduce the amount of files that were changed and get rid of some non elevation_mapping_cupy packages and I switched the build type to ament_cmake_python to enable installing both python and C++.
Additionally, I updated the docker file and provided a VS Code Devcontainer to ease testing. I added some instructions to the top-level README.md, but this probably needs reorganized a bit.
Please take a look and let me know if anyone finds this useful.
P.S. I think that this PR can replace the #107 as it combines those commits with the ros2_py branch although maybe this new branch should be called ros2_humble instead since it supports python and C++.