Skip to content

Julian/feature/ros2 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 57 commits into
base: main
Choose a base branch
from
Open

Julian/feature/ros2 #7

wants to merge 57 commits into from

Conversation

nubertj
Copy link
Member

@nubertj nubertj commented May 27, 2025

FYI to track, so far merged in your changes, now will make a general ament wrapper and make sure that smb is still compiling

deepanaishtaweera and others added 30 commits May 19, 2025 10:26
…nventions, including updated includes, parameter handling, and subscription methods. Transition from ros::NodeHandle to rclcpp::Node and adjust message types accordingly for improved compatibility with ROS 2 architecture.
…icTransforms and simplify initialization with only the node pointer.
…raph and smb_estimator_graph_replay, enhancing maintainability and aligning with ROS 2 conventions.
…eading and writing bags, improving performance and compatibility with ROS 2 conventions.
…_in_folder.py, adding support for covariance data and improving error handling.
…y points for console scripts. Introduce new resource file for graph_msf_ros2.
…ings for Cholesky factorization and marginals computation, while commenting out the center reference frames parameter.
@nubertj
Copy link
Member Author

nubertj commented May 27, 2025

this is building for me, and still working with all old catkin packages.
smb_estimator_graph_ros2 is building for me, but I can't test it as I do not have any data. The cool thing about this setup is that graph_msf is entirely independent of ament or catkin, and just works with both.

Also we do not need a graph_msf_ament, as colcon is much more cmake-like.
Feel free to test this version. I kept all your code changes of smb_estimator_graph_ros2, just moved it to a different location.
This version I would be happy to merge to main, as it also still works with all the catkin dependencies.

@nubertj
Copy link
Member Author

nubertj commented May 27, 2025

@deepanaishtaweera if you have a rosbag that works it would be great, otherwise it might get a bit tight time-wise

@nubertj nubertj requested a review from mantelt May 27, 2025 20:42
@nubertj nubertj marked this pull request as ready for review May 27, 2025 20:42
@nubertj nubertj mentioned this pull request May 28, 2025
@deepanaishtaweera
Copy link
Collaborator

I will test this in sim first and once the rosbag is ready we can test on the real data.

nubertj and others added 4 commits June 11, 2025 02:25
* reduce ament further

* Update IMU subscription topic in GraphMsfRos2 to '/imu_topic'

* Update lioOdometryRate in smb_graph_params.yaml from 10 to 100

* fix sim time arg

* Remove obsolete YAML configuration files for compslam and dumped parameters in smb_estimator_graph_ros2.

* Update realTimeSmootherLag parameter in core_graph_params.yaml from 2.0 to 10.0

* Remove obsolete YAML configuration files for compslam and dumped parameters in smb_estimator_graph_ros2.

* Add odometry flags and update SmbStaticTransforms logic

- Introduced flags for LIO, VIO, and wheel odometry in SmbStaticTransforms.
- Updated SmbEstimator to set these flags during initialization.
- Modified findTransformations method to conditionally perform transformations based on the new flags.

* remove python dependency, as it creates issues when reinitialziing workspace

---------

Co-authored-by: dishtaweera <[email protected]>
@deepanaishtaweera
Copy link
Collaborator

i'm testing this branch now. @nubertj built allright so far.

@deepanaishtaweera
Copy link
Collaborator

This branch working with ros2 launch smb_estimator_graph_ros2 smb_estimator_graph_sim.launch.py

@nubertj
Copy link
Member Author

nubertj commented Jun 11, 2025

Just updated to a running version for me @deepanaishtaweera.

I can't play the mcap file in my ros2 container, and will now try to switch to yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants