fix(tests): Various fixes for the testing framework #55
Conversation
|
|
uristdwarf
force-pushed
the
coredumps-fixes
branch
from
2606952 to
dad6327
Compare
|
Please, check the guidelines for a commit message |
This is a series of 3 commits: tidy(tests): Remove unnecessary ticks This messes up some editor syntax highlighting fix(tests): Fix binary output being outputted The variable used in the conditional is different from the actual filename used. This conditional would always succeed since awk would return 0 if the conditional in awk would not match, which it didn't since stdout was empty (only stderr was populated with the error message, but it is disregarded). fix(tests): Coredumps not being generated At least 3 years ago, `sudo` had a change of behaviour regarding coredumps. This fixes that by setting the default for cores as the system.
Removing the backticks caused the output to not behave correctly. This fixes that by ensuring they remain on one line.
lgsilva3087
force-pushed
the
coredumps-fixes
branch
from
52eb0a5 to
f4ac140
Compare
There was a problem hiding this comment.
Please, reword the commit message (maybe you intend to squash both commits, but the current message refers other commits that are not there anymore). Also, notice some of these changes are not atomic (in a sense that if you need to revert a commit, it wouldn't produce collateral effects)
I've reworded it a bit so it looks like a full commit. On the last part, I mostly agree but these are 2 rather trivial changes not related to the main codebase (only relating to tests), so it's not worth the effort to split these apart, especially since the last point on the bullet list is dependent on the second. |
* Remove unnecessary ticks This messes up some editor syntax highlighting * Fix binary output being outputted The variable used in the conditional is different from the actual filename used. This conditional would always succeed since awk would return 0 if the conditional in awk would not match, which it didn't since stdout was empty (only stderr was populated with the error message, but it is disregarded). * Fix coredumps not being generated At least 3 years ago, `sudo` had a change of behavior regarding coredumps. This fixes that by setting the default for cores as the system.
This is a series of 3 commits:
tidy(tests): Remove unnecessary ticks
This messes up some editor syntax highlighting
fix(tests): Fix binary output being outputted
The variable used in the conditional is different from the actual
filename used. This conditional would always succeed since awk would
return 0 if the conditional in awk would not match, which it didn't
since stdout was empty (only stderr was populated with the error
message, but it is disregarded).
fix(tests): Coredumps not being generated
At least 3 years ago,
sudohad a change of behaviour regardingcoredumps. This fixes that by setting the default for cores as the
system.