Skip to content

fix(server): let load args override saved args - #3204

Merged
bitgamma merged 1 commit into
mainfrom
fl0rianr/server_args_adapt
Aug 18, 2026
Merged

fix(server): let load args override saved args#3204
bitgamma merged 1 commit into
mainfrom
fl0rianr/server_args_adapt

Conversation

@fl0rianr

Copy link
Copy Markdown
Collaborator

Summary

Make explicitly provided *_args in /load replace the saved value for the same key before merge_args is applied. Lower-priority architecture, backend, and global args can still be merged normally.

Follow-up/related to #3082.

Scope

  • This PR addresses one clear issue or change.
  • I reviewed the full diff myself before submitting.
  • I removed unrelated local changes.
  • I kept refactoring separate unless it is required for this change.

Testing

  • Code builds without errors locally.
  • I described the testing performed below.

Testing details:

  • Updated test_012lc to verify request llamacpp_args replace the saved same-key layer without modifying the saved value.
  • Added test_012le to verify request args still merge with lower-priority global args and win on conflicting flags.

Documentation

  • Documentation is not affected by this change.

Breaking Changes

  • This PR does not introduce breaking changes.

AI-assisted contribution

Please select one:

  • I used AI tools for this PR.

If AI tools were used:

  • I verified that I understand the changes.
  • I checked for hallucinated APIs, unrelated changes, and incorrect assumptions.

@fl0rianr fl0rianr added this to the GUI ui/ux - release blockers milestone Aug 18, 2026
@github-actions github-actions Bot added the bug Something isn't working label Aug 18, 2026

@bitgamma bitgamma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bitgamma
bitgamma added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit 68b5a1b Aug 18, 2026
81 of 82 checks passed
@bitgamma
bitgamma deleted the fl0rianr/server_args_adapt branch August 18, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants