fix(server): let load args override saved args - #3204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make explicitly provided
*_argsin/loadreplace the saved value for the same key beforemerge_argsis applied. Lower-priority architecture, backend, and global args can still be merged normally.Follow-up/related to #3082.
Scope
Testing
Testing details:
test_012lcto verify requestllamacpp_argsreplace the saved same-key layer without modifying the saved value.test_012leto verify request args still merge with lower-priority global args and win on conflicting flags.Documentation
Breaking Changes
AI-assisted contribution
Please select one:
If AI tools were used: