Skip to content

Fix PasswordBox #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix PasswordBox #1547

wants to merge 2 commits into from
+40 −88

Conversation

Nuklon
Copy link

@Nuklon Nuklon commented Oct 17, 2025 •
edited
Loading

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

There are many issues inside PasswordBox:

  1. If you paste a text that's longer than the current text, only the characters at the end are changed. For example. If you have "test" and paste "hello world", it'll become "testo world".
  2. If you paste in multiple characters, often only one gets inserted due to breaking early.
  3. Selecting multiple characters, and then paste a shorter one, you'll get a mishmash of characters.
  4. Exception thrown when binding to a null Password.

This PR addresses all issues by simply using the TextChanges passed in with the event.

@Nuklon Nuklon requested a review from pomianowski as a code owner October 17, 2025 10:14
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. PR Pull request dotnet release labels Oct 17, 2025
@Nuklon
Copy link
Author

Nuklon commented Oct 17, 2025

@pomianowski If you have some time, there are a lot of PRs to review/merge.

@Nuklon Nuklon mentioned this pull request Oct 17, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pomianowski pomianowski Awaiting requested review from pomianowski pomianowski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

controls Changes to the appearance or logic of custom controls. dotnet PR Pull request release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Nuklon