Skip to content

Issue #91: update search() to work with search/jql #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

herbdool
Copy link

Fixes #91

Copy link
Contributor

@RomainMILLAN RomainMILLAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see new parameters on function, mayby un update of doc is necessary ?

'jql' => $jql,
]);

$ret = $this->exec('search//approximate-count', $data, 'POST');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

propal : search/approximate-count

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomainMILLAN it's got a double slash because single slash gets stripped out. I'm not sure why but decided to just work around it.

@herbdool
Copy link
Author

herbdool commented May 7, 2025

@RomainMILLAN I could include the doc changes, if the approach in this PR is acceptable to the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation of search enpoints
2 participants